Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated docs about asyncio.start_server() #126896

Closed
beavailable opened this issue Nov 16, 2024 · 1 comment
Closed

Outdated docs about asyncio.start_server() #126896

beavailable opened this issue Nov 16, 2024 · 1 comment
Labels
docs Documentation in the Doc dir topic-asyncio

Comments

@beavailable
Copy link
Contributor

beavailable commented Nov 16, 2024 •
edited by bedevere-app bot
Loading

Documentation

Since 3.13, the function asyncio.start_server() has added a parameter named keep_alive (see #112485), but the docs didn't completely update in that PR, so the website still shows the old function signature (see https://docs.python.org/3/library/asyncio-stream.html#asyncio.start_server).

It's actually my fault and I'll submit a PR to fix it.

Linked PRs
@beavailable beavailable added the docs Documentation in the Doc dir label Nov 16, 2024
@bedevere-app bedevere-app bot mentioned this issue Nov 16, 2024
Merged
@github-project-automation github-project-automation bot moved this to Todo in asyncio Nov 16, 2024
@sobolevn sobolevn changed the title Outdated docs about asyncio.start_erver() Outdated docs about asyncio.start_server() Nov 16, 2024
1st1 pushed a commit that referenced this issue Nov 17, 2024
@beavailable
gh-126896: Fix docs about asyncio.start_server() (#126897)
0c5c809
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 17, 2024
@beavailable @miss-islington
pythongh-126896: Fix docs about asyncio.start_server() (pythonGH-12…
f91c150 
…6897)

(cherry picked from commit 0c5c809)

Co-authored-by: beavailable <beavailable@proton.me>
@bedevere-app bedevere-app bot mentioned this issue Nov 17, 2024
Merged
gpshead pushed a commit that referenced this issue Nov 24, 2024
@miss-islington @beavailable
[3.13] gh-126896: Fix docs about asyncio.start_server() (GH-126897) (…
a8e69fc 
…GH-126934)

gh-126896: Fix docs about `asyncio.start_server()` (GH-126897)
(cherry picked from commit 0c5c809)

Co-authored-by: beavailable <beavailable@proton.me>
@gpshead
Copy link
Member

gpshead commented Nov 24, 2024

thanks!

@gpshead gpshead closed this as completed Nov 24, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in asyncio Nov 24, 2024
@github-actions github-actions bot mentioned this issue Dec 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation in the Doc dir topic-asyncio
Projects
asyncio
Status: Done
docs issues
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gpshead @hugovk @beavailable