Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.10: GHA Docs builds of PRs fail because they use removed actions/upload-artifact: v3 #129641

Closed
encukou opened this issue Feb 4, 2025 · 3 comments
Labels
3.9 only security fixes 3.10 only security fixes infra CI, GitHub Actions, buildbots, Dependabot, etc. type-bug An unexpected behavior, bug, or error

Comments

@encukou
Copy link
Member

encukou commented Feb 4, 2025

3.10 & 3.9 PRs fail on documentation builds with:

Error: This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v3. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

For example: https://github.com/python/cpython/actions/runs/13077929192/job/36494533879?pr=129529

Linked PRs

@encukou encukou added 3.10 only security fixes 3.9 only security fixes infra CI, GitHub Actions, buildbots, Dependabot, etc. labels Feb 4, 2025
@picnixz picnixz added the type-bug An unexpected behavior, bug, or error label Feb 4, 2025
@encukou
Copy link
Member Author

encukou commented Feb 4, 2025

Note that for newer branches, docs builds were switched to Netlify (in #100330) and then Read the Docs; we no longer use upload-artifact there.
3.10 and 3.9 have a stub Read the Docs config file that disables the builds there (which currently fails, see #129509).

encukou added a commit to encukou/cpython that referenced this issue Feb 4, 2025
pablogsal pushed a commit that referenced this issue Feb 13, 2025
#129642)

* [3.10] gh-129641: Switch Docs GHA build to actions/upload-artifact@v4

Add options for backwards compatibility, from the docs at:
https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changes

* Python Tutorial typo fix (#128077)

Backported form commit: 5a584c8

This is a trivial change meant to trigger a Docs build.

* Use Python 3.12 for the 3.10 docs build

The pinned version of Sphinx requires `imghdr`, removed in Python 3.13.

---------

Co-authored-by: shallow-beach <96891913+shallow-beach@users.noreply.github.com>
@StanFromIreland
Copy link
Contributor

StanFromIreland commented Feb 13, 2025

3.9 currently builds cpython from source like so

    - name: 'Configure CPython'
      run: ./configure --with-pydebug
    - name: 'Build CPython'
      run: make -j4

but I it builds from the 3.9 branch it checks out so there is no need to change anything.

There is still actions/upload-artifact@v3 to be updated. I can do it for you if you are busy.

3.9 example.

@encukou
Copy link
Member Author

encukou commented Feb 14, 2025

Thanks! I already had the 3.9 PR half-done when I saw your message.

hugovk pushed a commit that referenced this issue Feb 18, 2025
…130114)

Co-authored-by: shallow-beach <96891913+shallow-beach@users.noreply.github.com>
fix (#128077)
@encukou encukou closed this as completed Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.9 only security fixes 3.10 only security fixes infra CI, GitHub Actions, buildbots, Dependabot, etc. type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

3 participants