-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamline repr(partial object) #72249
Comments
This is a followup to bpo-27137, where it was found out the repr of a partial object includes the module (i.e. 'functools') only if it's not a subclass. This behaviour is surprising at best. Attached patch streamlines the reprs of partial objects to always include the module. Raymond, do you remember why this approach was taken? Looking at the code, it seems it was just the easiest way to go about it. Side-note: I couldn't run the test suite since I ran into bpo-28061, so I just did manual testing. |
The PR is ready for review. @serhiy-storchaka |
…01910) Co-authored-by: Anilyka Barry <vgr255@live.ca>
Thank you for your contribution @Vgr255 and @furkanonder. I do not think that it is worth to backport this change. |
…pythonGH-101910) Co-authored-by: Anilyka Barry <vgr255@live.ca>
…pythonGH-101910) Co-authored-by: Anilyka Barry <vgr255@live.ca>
…pythonGH-101910) Co-authored-by: Anilyka Barry <vgr255@live.ca>
…pythonGH-101910) Co-authored-by: Anilyka Barry <vgr255@live.ca>
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
Linked PRs
The text was updated successfully, but these errors were encountered: