Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have os.PathLike inherit from typing.Protocol #83066

Closed
brettcannon opened this issue Nov 21, 2019 · 2 comments
Closed

Have os.PathLike inherit from typing.Protocol #83066

brettcannon opened this issue Nov 21, 2019 · 2 comments
Labels
3.9 only security fixes stdlib Python modules in the Lib dir

Comments

@brettcannon
Copy link
Member

BPO 38885
Nosy @brettcannon

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-11-21.19:50:07.710>
created_at = <Date 2019-11-21.19:49:42.040>
labels = ['library', '3.9']
title = 'Have os.PathLike inherit from typing.Protocol'
updated_at = <Date 2019-11-21.19:50:07.708>
user = 'https://github.com/brettcannon'

bugs.python.org fields:

activity = <Date 2019-11-21.19:50:07.708>
actor = 'brett.cannon'
assignee = 'none'
closed = True
closed_date = <Date 2019-11-21.19:50:07.710>
closer = 'brett.cannon'
components = ['Library (Lib)']
creation = <Date 2019-11-21.19:49:42.040>
creator = 'brett.cannon'
dependencies = []
files = []
hgrepos = []
issue_num = 38885
keywords = []
message_count = 2.0
messages = ['357206', '357207']
nosy_count = 1.0
nosy_names = ['brett.cannon']
pr_nums = []
priority = 'normal'
resolution = 'rejected'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue38885'
versions = ['Python 3.9']

@brettcannon
Copy link
Member Author

Since os.PathLike explicitly defines a a protocol, it would make sense to have it inherit from typing.Protocol instead of abc.ABC.

@brettcannon brettcannon added 3.9 only security fixes stdlib Python modules in the Lib dir labels Nov 21, 2019
@brettcannon
Copy link
Member Author

Closing as importing 'typing' in 'os' is probably too much and would impact start-up time.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.9 only security fixes stdlib Python modules in the Lib dir
Projects
None yet
Development

No branches or pull requests

1 participant