Define SOABI, LIBRARY, LDLIBRARY and LIBPL on Windows

[zooba]

BPO	44236
Nosy	@pfmoore, @tjguk, @zware, @zooba

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2021-05-25.15:15:02.518>
labels = ['3.10', 'OS-windows', '3.11']
title = 'Define SOABI, LIBRARY, LDLIBRARY and LIBPL on Windows'
updated_at = <Date 2021-05-25.15:18:34.574>
user = 'https://github.com/zooba'

bugs.python.org fields:

activity = <Date 2021-05-25.15:18:34.574>
actor = 'steve.dower'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Windows']
creation = <Date 2021-05-25.15:15:02.518>
creator = 'steve.dower'
dependencies = []
files = []
hgrepos = []
issue_num = 44236
keywords = []
message_count = 2.0
messages = ['394368', '394369']
nosy_count = 4.0
nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'steve.dower']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue44236'
versions = ['Python 3.10', 'Python 3.11']

Linked PRs

• gh-88402: Add new sysconfig variables on Windows (GH-110049) #110049

[zooba]

Python on Windows currently has no values in sysconfig to locate the lib files for building. Though these are very predictable (for now), it would be nice to have them in the same place as for other platforms.

I propose defining the following config vars in sysconfig:

LIBRARY=Path(_winapi.GetModuleFileName(sys.dllhandle)).stem
LDLIBRARY=Path(_winapi.GetModuleFileName(sys.dllhandle)).name
LIBPL=Path(sys.prefix) / "libs"
SOABI=<SO but without '.' and '.pyd'>

Are there better shared names for these? Or others that should be added?

[zooba]

Should actually be:

LIBPL=Path(sysconfig.get_config_var("installed_base")) / "libs"

[tasty0tomato]

Tools/freeze.py may not work on Windows because of this.

cpython/Tools/freeze/freeze.py

Line 239 in 04cc427

configdir = sysconfig.get_config_var('LIBPL')

[zooba]

Well, we know it currently works well enough to pass tests, so there must be some other way that it handles that variable not currently existing. It's possible though that providing that value would cause it to start failing.

And now I've been reminded of this issue, ping @FFY00

[FFY00]

I propose defining the following config vars in sysconfig:

I think it's a good idea, we could definitely use this downstream until we have a better place to expose this information. Adding this should be fairly easy, the new variables just need to be added to _init_non_posix, if anyone wants to open a PR.

cpython/Lib/sysconfig.py

Line 540 in 84181c1

def _init_non_posix(vars):

I'd also probably add a test to make sure they match with the values in importlib.machinery.EXTENSION_SUFFIXES

Should actually be:

Yes, it should be derived from installed_base.

[colesbury]

Adding this should be fairly easy, the new variables just need to be added to _init_non_posix, if anyone wants to open a PR.

I can put up a PR for this. I think having SOABI consistent defined will be useful for PEP 703, and it'd be helpful to have sysconfig.get_config_var('Py_NOGIL') work on Windows as well.

[FFY00]

@colesbury, yeah please do! I'd be happy to review it.

[FFY00]

GH-110049 landed thanks to @colesbury, which implemented this, but with the following differences from the original proposal:

• LIBDIR was used instead of LIBPL, as it better matches the POSIX semantics (discussion)
• LIBRARY exposes the libpython DLL name instead of the path to the directory where it is contained (discussion)
• Py_NOGIL was also added