Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_faulthandler is too strict in threaded checks #92006

Closed
jkloth opened this issue Apr 27, 2022 · 2 comments
Closed

test_faulthandler is too strict in threaded checks #92006

jkloth opened this issue Apr 27, 2022 · 2 comments
Labels
pending The issue will be closed if no feedback is provided type-bug An unexpected behavior, bug, or error

Comments

@jkloth
Copy link
Contributor

jkloth commented Apr 27, 2022

In test_faulthandler.check_dump_traceback_threads() the regex is being overly strict in regard to the line number for the run() method.

It is possible for a context switch to happen between the running.set() and stop.wait() calls which leads to the checking regex to fail. See AMD64 Windows11 3.x/1225/test for an example where this breaks.

Linked PRs

@jkloth jkloth added the type-bug An unexpected behavior, bug, or error label Apr 27, 2022
jkloth added a commit to jkloth/cpython that referenced this issue Apr 27, 2022
@hauntsaninja
Copy link
Contributor

Is this still a problem on main? PR welcome if so!

@hauntsaninja hauntsaninja added the pending The issue will be closed if no feedback is provided label Jan 1, 2023
@arhadthedev
Copy link
Member

The referred logs did not survive till these days but I guess that the non-mutated code chunk does not change line numbers of methods inside. Also, this error does not manifest itself at all so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending The issue will be closed if no feedback is provided type-bug An unexpected behavior, bug, or error
Projects
Development

No branches or pull requests

3 participants