Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set loader for namespace packages in PathFinder.find_spec #92205

Open
FFY00 opened this issue May 2, 2022 · 2 comments
Open

Set loader for namespace packages in PathFinder.find_spec #92205

FFY00 opened this issue May 2, 2022 · 2 comments
Labels
topic-importlib type-bug An unexpected behavior, bug, or error

Comments

@FFY00
Copy link
Member

FFY00 commented May 2, 2022 •
edited
Loading

Bug report

While fixing #84530, I ran into the issue of the loader sometimes not being set for namespace packages. After talking with @ericvsmith, it seems that might have just been overlooked.

Responsible code:

cpython/Lib/importlib/_bootstrap_external.py

Line 1511 in ebb8b51

return spec

Your environment

  • CPython versions tested on: main
  • Operating system and architecture:
@FFY00 FFY00 added the type-bug An unexpected behavior, bug, or error label May 2, 2022
@warsaw
Copy link
Member

warsaw commented May 2, 2022

@FFY00 Are you going to submit a PR?

@FFY00
Copy link
Member Author

FFY00 commented May 2, 2022

Yes, working on it.

@FFY00 FFY00 mentioned this issue May 3, 2022
Open
FFY00 added a commit to FFY00/cpython that referenced this issue May 3, 2022
@FFY00
pythongh-92205: set loader for namespace packages PathFinder.find_spec
6f8ecf6
@ericsnowcurrently ericsnowcurrently mentioned this issue May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic-importlib type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@warsaw @FFY00