Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

__future__.annotations has inaccurate mandatoryRelease value #93626

Closed
KotlinIsland opened this issue Jun 9, 2022 · 8 comments · Fixed by #93628
Closed

__future__.annotations has inaccurate mandatoryRelease value #93626

KotlinIsland opened this issue Jun 9, 2022 · 8 comments · Fixed by #93628
Labels
3.11 only security fixes deferred-blocker docs Documentation in the Doc dir topic-typing

Comments

@KotlinIsland
Copy link
Contributor

KotlinIsland commented Jun 9, 2022 •
edited
Loading

future.__annotations__ has been postponed, yet it is active in the 3.11 betas.

>A clear and concise description of the issue.

https://docs.python.org/3.11/whatsnew/3.11.html

This page doesn't mention pep 563 at all.
@KotlinIsland KotlinIsland added the docs Documentation in the Doc dir label Jun 9, 2022
@JelleZijlstra
Copy link
Member

PEP 563 has been deferred. There will be no behavior changes around the future import in 3.11. See https://docs.python.org/3.10/library/__future__.html#id1

@JelleZijlstra JelleZijlstra closed this as not planned Won't fix, can't repro, duplicate, stale Jun 9, 2022
@KotlinIsland
Copy link
Contributor Author

KotlinIsland commented Jun 9, 2022 •
edited
Loading

cpython/Lib/__future__.py

Lines 145 to 147 in 68f6a5d

annotations = _Feature((3, 7, 0, "beta", 1),
(3, 11, 0, "alpha", 0),
CO_FUTURE_ANNOTATIONS)

Does this need to be updated then? All the 3.11 releases so far have annotations turned on.

@KotlinIsland
Copy link
Contributor Author

KotlinIsland commented Jun 9, 2022 •
edited
Loading

Maybe the 'What's New' could mention that it has been delayed again.

@KotlinIsland KotlinIsland mentioned this issue Jun 9, 2022
Merged
@graingert
Copy link
Contributor

graingert commented Jun 18, 2022 •
edited
Loading

could it be set to None instead?

cpython/Lib/__future__.py

Lines 35 to 36 in f4c0348

MandatoryRelease may also be None, meaning that a planned feature got
dropped.

the wording could be changed to say:

MandatoryRelease may also be None, meaning that a planned feature has
no predicted release or has been dropped.

@KotlinIsland
Copy link
Contributor Author

I've made that change.

@KotlinIsland KotlinIsland mentioned this issue Jun 19, 2022
Closed
@KotlinIsland KotlinIsland changed the title 3.11 What's new doesn't mention future.__annotations__ becoming active future.__annotations__ is active in 3.11 betas Jun 29, 2022
@KotlinIsland
Copy link
Contributor Author

@JelleZijlstra Could this be reopened?

@JelleZijlstra JelleZijlstra reopened this Jun 29, 2022
@graingert
Copy link
Contributor

Imho this is a release blocker

@zware zware changed the title future.__annotations__ is active in 3.11 betas __future__.annotations has inaccurate mandatoryRelease value Jun 30, 2022
@zware
Copy link
Member

zware commented Jun 30, 2022

I see no need for this to block beta 4, but it should be resolved before final release.

/cc @pablogsal

@zware zware added the 3.11 only security fixes label Jun 30, 2022
@pablogsal pablogsal mentioned this issue Jul 1, 2022
Closed
KotlinIsland added a commit to KotlinIsland/cpython that referenced this issue Jul 3, 2022
@KotlinIsland
pythongh-93626: Set the release for __future__.annotations to None
fd66e10
@bedevere-bot bedevere-bot mentioned this issue Jul 5, 2022
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 5, 2022
@KotlinIsland @miss-islington
pythongh-93626: Set the release for __future__.annotations to None (
b7ccccb 
pythonGH-93628)

Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>
(cherry picked from commit 4791a8a)

Co-authored-by: KotlinIsland <65446343+KotlinIsland@users.noreply.github.com>
ambv pushed a commit that referenced this issue Jul 5, 2022
@KotlinIsland @gvanrossum
gh-93626: Set the release for __future__.annotations to None (GH-…
4791a8a 
…93628)

Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>
ambv pushed a commit that referenced this issue Jul 5, 2022
@miss-islington @KotlinIsland
gh-93626: Set the release for __future__.annotations to None (GH-…
99a0668 
…93628) (GH-94553)

Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>
(cherry picked from commit 4791a8a)

Co-authored-by: KotlinIsland <65446343+KotlinIsland@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.11 only security fixes deferred-blocker docs Documentation in the Doc dir topic-typing
Projects
Release and Deferred blockers 🚫
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-93626: Set the release for __future__.annotations to None KotlinIsland/cpython
4 participants
@graingert @JelleZijlstra @zware @KotlinIsland