AC: Params named module with custom C names are rejected

[erlend-aasland]

Feature or enhancement

Currently, Argument Clinic will not allow parameters named module, even though they've got a custom C name. For example, this clinic input is rejected:

/*[clinic input]
mod.func

    module as mod: object

[clinic start generated code]*/

AC complains with "You can't have two parameters named 'module'!", even though there is no naming collision on the C level. This issue prevents AC conversion of some functions and methods in the code base, for example warn_explicit() in Python/_warnings.c. A workaround is to provide a custom name to the self converter, however I view that as a hack; it adds unneeded clinic code.

Hack/workaround

/*[clinic input]
mod.func

    _module: self(type="PyObject *")
    module as mod: object

[clinic start generated code]*/

Pitch

The fix is easy (its almost a one-liner), and it unlocks more AC conversions, without requiring unneeded hacks.

Patch

diff.txt

[erlend-aasland]

Implemented in:

• main: gh-94430: Allow parameters named module or self with custom C names in Argument Clinic #94431
• 3.11: [3.11] gh-94430: Allow params named module or self with custom C names in AC (GH-94431) #94649
• 3.10: [3.10] gh-94430: Allow params named module or self with custom C names in AC (GH-94431) #94650