Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "with permission from edgedb" header is confusing for people trying to reuse the code #95724

Closed
graingert opened this issue Aug 5, 2022 · 4 comments

Comments

@graingert
Copy link
Contributor

graingert commented Aug 5, 2022

I think Lib/asyncio/taskgroups.py should include the Apache license. The "with permission from edgedb" header is confusing for people trying to reuse the code

Originally posted by @graingert in #95649 (comment)

@graingert graingert changed the title I think Lib/asyncio/taskgroup.py should include the Apache license. I think Lib/asyncio/taskgroups.py should include the Apache license. Aug 5, 2022
@graingert
Copy link
Contributor Author

graingert commented Aug 5, 2022

Currently the license header says this:

# Adapted with permission from the EdgeDB project.

I think it should include this

https://github.com/edgedb/edgedb/blob/868f3d37409435a3b6bbf8ea20ec6c193e63f076/edb/common/taskgroup.py#L1-L17

@graingert
Copy link
Contributor Author

I also think there's a few changes that were backported from CPython to edgedb and then back again which need the PSF copyright header, maybe?

@gvanrossum
Copy link
Member

I specifically asked @1st1 what to do with the license/copyright notice from EdgeDb and he approved the current text. IIUC the EdgeDb CLA allows him to do that.

graingert added a commit to graingert/cpython that referenced this issue Aug 5, 2022
Previously the permission notice was relative to the current file, which made it unclear if people copying taskgroups.py would also need to gain permission from edgedb
1st1 added a commit to 1st1/cpython that referenced this issue Aug 10, 2022
1st1 added a commit to 1st1/cpython that referenced this issue Aug 10, 2022
@gvanrossum
Copy link
Member

@graingert Please see #95847 for Yury's suggested changes.

@graingert graingert changed the title I think Lib/asyncio/taskgroups.py should include the Apache license. The "with permission from edgedb" header is confusing for people trying to reuse the code Aug 10, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 11, 2022
(cherry picked from commit 7da4937)

Co-authored-by: Yury Selivanov <yury@edgedb.com>
miss-islington added a commit that referenced this issue Aug 11, 2022
(cherry picked from commit 7da4937)

Co-authored-by: Yury Selivanov <yury@edgedb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants