-
-
Notifications
You must be signed in to change notification settings - Fork 31.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The "with permission from edgedb" header is confusing for people trying to reuse the code #95724
Comments
Currently the license header says this: cpython/Lib/asyncio/taskgroups.py Line 1 in 834064c
I think it should include this |
I also think there's a few changes that were backported from CPython to edgedb and then back again which need the PSF copyright header, maybe? |
I specifically asked @1st1 what to do with the license/copyright notice from EdgeDb and he approved the current text. IIUC the EdgeDb CLA allows him to do that. |
Previously the permission notice was relative to the current file, which made it unclear if people copying taskgroups.py would also need to gain permission from edgedb
@graingert Please see #95847 for Yury's suggested changes. |
(cherry picked from commit 7da4937) Co-authored-by: Yury Selivanov <yury@edgedb.com>
I think Lib/asyncio/taskgroups.py should include the Apache license. The "with permission from edgedb" header is confusing for people trying to reuse the code
Originally posted by @graingert in #95649 (comment)
The text was updated successfully, but these errors were encountered: