Skip to content

Functional tests for argument clinic #96002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kumaraditya303 opened this issue Aug 15, 2022 · 0 comments
Closed

Functional tests for argument clinic #96002

kumaraditya303 opened this issue Aug 15, 2022 · 0 comments
Labels
3.12 only security fixes tests Tests in the Lib/test dir topic-argument-clinic

Comments

@kumaraditya303
Copy link
Contributor

kumaraditya303 commented Aug 15, 2022 •
edited by bedevere-bot
Loading

Currently there are no functional tests for argument clinic and the present tests mostly verify generated code not the runtime behavior. This can lead to bugs like #32092 so adding tests would help avoid such bugs.

A new module with functions using all function signatures can be created which will return the tuple of the args so that testing it would be easy.
@kumaraditya303 kumaraditya303 added tests Tests in the Lib/test dir topic-argument-clinic 3.12 only security fixes labels Aug 15, 2022
@kumaraditya303 kumaraditya303 mentioned this issue Aug 15, 2022
Merged
@bedevere-bot bedevere-bot mentioned this issue Aug 22, 2022
Merged
erlend-aasland added a commit that referenced this issue Nov 21, 2022
@colorfulappl @kumaraditya303 @erlend-aasland
gh-96002: Add functional test for Argument Clinic (#96178)
c450c8c 
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
This was referenced Nov 24, 2022
Merged
Merged
Closed
colorfulappl added a commit to colorfulappl/cpython that referenced this issue Dec 14, 2022
@colorfulappl @kumaraditya303 @erlend-aasland
pythongh-96002: Add functional test for Argument Clinic (python#96178)
f1f15f0 
(cherry picked from commit c450c8c)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot bedevere-bot mentioned this issue Dec 14, 2022
Merged
colorfulappl added a commit to colorfulappl/cpython that referenced this issue Dec 14, 2022
@colorfulappl @kumaraditya303 @erlend-aasland
pythongh-96002: Add functional test for Argument Clinic (python#96178)
6424170 
(cherry picked from commit c450c8c)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot bedevere-bot mentioned this issue Dec 14, 2022
Merged
kumaraditya303 added a commit that referenced this issue Dec 17, 2022
@colorfulappl @kumaraditya303 @erlend-aasland
[3.11] gh-96002: Add functional test for Argument Clinic (GH-96178) (#…
dd323af 
…100230)

(cherry picked from commit c450c8c)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
kumaraditya303 added a commit that referenced this issue Dec 17, 2022
@colorfulappl @kumaraditya303 @erlend-aasland
[3.10] gh-96002: Add functional test for Argument Clinic (GH-96178) (#…
3144aca 
…100232)

(cherry picked from commit c450c8c)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.12 only security fixes tests Tests in the Lib/test dir topic-argument-clinic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erlend-aasland @kumaraditya303