Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Argument name mismatch in _thread.lock.acquire() docs #96448

Closed
dgiger42 opened this issue Aug 31, 2022 · 0 comments
Closed

Argument name mismatch in _thread.lock.acquire() docs #96448

dgiger42 opened this issue Aug 31, 2022 · 0 comments
Labels
docs Documentation in the Doc dir

Comments

@dgiger42
Copy link
Contributor

Documentation

The documentation for _thread.lock.acquire() says that its first argument is called waitflag, but it's actually called blocking.
@dgiger42 dgiger42 added the docs Documentation in the Doc dir label Aug 31, 2022
@dgiger42 dgiger42 changed the title Argument name mismatch in _thread.lock.aquire() docs Argument name mismatch in _thread.lock.acquire() docs Aug 31, 2022
@bedevere-bot bedevere-bot mentioned this issue Aug 31, 2022
Merged
orsenthil pushed a commit that referenced this issue Oct 4, 2022
@dgiger42
gh-96448: fix documentation for _thread.lock.acquire (#96449)
7acb93f 
* fix documentation for _thread.lock.acquire

* update formatting of _thread.lock.acquire() doc
@bedevere-bot bedevere-bot mentioned this issue Oct 4, 2022
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 4, 2022
@dgiger42 @miss-islington
pythongh-96448: fix documentation for _thread.lock.acquire (pythonGH-…
4e47fa7 
…96449)

* fix documentation for _thread.lock.acquire

* update formatting of _thread.lock.acquire() doc
(cherry picked from commit 7acb93f)

Co-authored-by: Daniel Giger <danielg3432@gmail.com>
@bedevere-bot bedevere-bot mentioned this issue Oct 4, 2022
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 4, 2022
@dgiger42 @miss-islington
pythongh-96448: fix documentation for _thread.lock.acquire (pythonGH-…
bc2b2f4 
…96449)

* fix documentation for _thread.lock.acquire

* update formatting of _thread.lock.acquire() doc
(cherry picked from commit 7acb93f)

Co-authored-by: Daniel Giger <danielg3432@gmail.com>
orsenthil pushed a commit that referenced this issue Oct 4, 2022
@miss-islington @dgiger42
[3.11] gh-96448: fix documentation for _thread.lock.acquire (GH-96449) (
d456982 
#97851)

gh-96448: fix documentation for _thread.lock.acquire (GH-96449)

* fix documentation for _thread.lock.acquire

* update formatting of _thread.lock.acquire() doc
(cherry picked from commit 7acb93f)

Co-authored-by: Daniel Giger <danielg3432@gmail.com>

Co-authored-by: Daniel Giger <danielg3432@gmail.com>
orsenthil pushed a commit that referenced this issue Oct 4, 2022
@miss-islington @dgiger42
[3.10] gh-96448: fix documentation for _thread.lock.acquire (GH-96449) (
f9b49b6 
#97852)

gh-96448: fix documentation for _thread.lock.acquire (GH-96449)

* fix documentation for _thread.lock.acquire

* update formatting of _thread.lock.acquire() doc
(cherry picked from commit 7acb93f)

Co-authored-by: Daniel Giger <danielg3432@gmail.com>

Co-authored-by: Daniel Giger <danielg3432@gmail.com>
mpage pushed a commit to mpage/cpython that referenced this issue Oct 11, 2022
@dgiger42 @mpage
pythongh-96448: fix documentation for _thread.lock.acquire (python#96449
de65e64 
)

* fix documentation for _thread.lock.acquire

* update formatting of _thread.lock.acquire() doc
pablogsal pushed a commit that referenced this issue Oct 22, 2022
@miss-islington @dgiger42 @pablogsal
[3.11] gh-96448: fix documentation for _thread.lock.acquire (GH-96449) (
ed772a8 
#97851)

gh-96448: fix documentation for _thread.lock.acquire (GH-96449)

* fix documentation for _thread.lock.acquire

* update formatting of _thread.lock.acquire() doc
(cherry picked from commit 7acb93f)

Co-authored-by: Daniel Giger <danielg3432@gmail.com>

Co-authored-by: Daniel Giger <danielg3432@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@orsenthil @dgiger42