Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronize links in other copies of HISTORY OF THE SOFTWARE #97519

Closed
serhiy-storchaka opened this issue Sep 24, 2022 · 2 comments
Closed

Synchronize links in other copies of HISTORY OF THE SOFTWARE #97519

serhiy-storchaka opened this issue Sep 24, 2022 · 2 comments
Labels
docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error

Comments

@serhiy-storchaka
Copy link
Member

HTTP links in the "HISTORY OF THE SOFTWARE" section of Doc/license.rst were converted to HTTPS. But there are other copies of this section in LICENSE and Mac/BuildScript/resources/License.rtf, and there is yet one related link in Misc/HISTORY. HTTP links were kept here. I though that we can upgrade these links because they are not part of third-party licenses and not part of the PSF license. But @gvanrossum said that "HISTORY OF THE SOFTWARE" is also important.

There are two ways to fix the discrepancy:

  1. Upgrade other occurrences of these HTTP links to HTTPS.
  2. Revert all or the part of upgrades of HTTP links to HTTPS in Doc/license.rst:
@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error docs Documentation in the Doc dir labels Sep 24, 2022
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Sep 24, 2022
@serhiy-storchaka
pythongh-97519: Synchronize links in other copies of HISTORY OF THE S…
794ea6c 
…OFTWARE

HTTP links in the "HISTORY OF THE SOFTWARE" section of Doc/license.rst
were converted to HTTPS in f62ff97.
But there were other copies of these links, which were left HTTP links.
@bedevere-bot bedevere-bot mentioned this issue Sep 24, 2022
Merged
@gvanrossum
Copy link
Member

Honestly I think fixing http links is like fixing whitespace. Let's just do it.

@gvanrossum gvanrossum removed their assignment Sep 25, 2022
serhiy-storchaka added a commit that referenced this issue Sep 25, 2022
@serhiy-storchaka
gh-97519: Synchronize links in other copies of HISTORY OF THE SOFTWARE (
ea4be27 
GH-97520)

HTTP links in the "HISTORY OF THE SOFTWARE" section of Doc/license.rst
were converted to HTTPS in f62ff97.
But there were other copies of these links, which were left HTTP links.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 25, 2022
@serhiy-storchaka @miss-islington
pythongh-97519: Synchronize links in other copies of HISTORY OF THE S…
dd25166 
…OFTWARE (pythonGH-97520)

HTTP links in the "HISTORY OF THE SOFTWARE" section of Doc/license.rst
were converted to HTTPS in f62ff97.
But there were other copies of these links, which were left HTTP links.
(cherry picked from commit ea4be27)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot bedevere-bot mentioned this issue Sep 25, 2022
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 25, 2022
@serhiy-storchaka @miss-islington
pythongh-97519: Synchronize links in other copies of HISTORY OF THE S…
df9f587 
…OFTWARE (pythonGH-97520)

HTTP links in the "HISTORY OF THE SOFTWARE" section of Doc/license.rst
were converted to HTTPS in f62ff97.
But there were other copies of these links, which were left HTTP links.
(cherry picked from commit ea4be27)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot bedevere-bot mentioned this issue Sep 25, 2022
Merged
@serhiy-storchaka
Copy link
Member Author

Thanks, Guido.

miss-islington added a commit that referenced this issue Sep 25, 2022
@miss-islington @serhiy-storchaka
gh-97519: Synchronize links in other copies of HISTORY OF THE SOFTWARE (
54bb8f9 
GH-97520)

HTTP links in the "HISTORY OF THE SOFTWARE" section of Doc/license.rst
were converted to HTTPS in f62ff97.
But there were other copies of these links, which were left HTTP links.
(cherry picked from commit ea4be27)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this issue Sep 25, 2022
@miss-islington @serhiy-storchaka
gh-97519: Synchronize links in other copies of HISTORY OF THE SOFTWARE (
96f8d36 
GH-97520)

HTTP links in the "HISTORY OF THE SOFTWARE" section of Doc/license.rst
were converted to HTTPS in f62ff97.
But there were other copies of these links, which were left HTTP links.
(cherry picked from commit ea4be27)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gvanrossum @serhiy-storchaka and others