Skip to content

sqlite3.connect parameter cached_statements default value is incorrect #97567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jiajunjie opened this issue Sep 26, 2022 · 3 comments · Fixed by #97568
Closed

sqlite3.connect parameter cached_statements default value is incorrect #97567

jiajunjie opened this issue Sep 26, 2022 · 3 comments · Fixed by #97568
Assignees
@erlend-aasland
Labels
3.10 only security fixes docs Documentation in the Doc dir topic-sqlite3

Comments

@jiajunjie
Copy link
Contributor

Documentation

cpython/Doc/library/sqlite3.rst

Line 260 in 8bdaf9b

factory=sqlite3.Connection, cached_statements=128, \

@jiajunjie jiajunjie added the docs Documentation in the Doc dir label Sep 26, 2022
@bedevere-bot bedevere-bot mentioned this issue Sep 26, 2022
Merged
@pochmann
Copy link
Contributor

pochmann commented Sep 26, 2022 •
edited
Loading

Where is it defined as 100? (The PR changes that doc to say 100.)

@jiajunjie
Copy link
Contributor Author

Where is it defined as 100? (The PR changes that doc to say 100.)

cpython/Modules/_sqlite/connection.c

Line 76 in 8bdaf9b

int cached_statements = 100;

@erlend-aasland
Copy link
Contributor

Thanks. FYI, the default limit was changed from 100 to 128 early in the 3.11 alpha phase (IIRC). The doc inconsistency pointed out stems from the backport of gh-94629.

@erlend-aasland erlend-aasland moved this to In Progress in sqlite3 issues Sep 27, 2022
erlend-aasland pushed a commit that referenced this issue Sep 27, 2022
@jiajunjie
[3.10] gh-97567: Fixup cached_statements default value in sqlite3.con…
6a41d11 
…nect docs (#97568)

This docs inconsistency was introduced by the 3.10 backport of gh-94629: gh-94646
@erlend-aasland erlend-aasland linked a pull request Sep 27, 2022 that will close this issue
[3.10] gh-97567: Fix cached_statements default value #97568
Merged
@erlend-aasland erlend-aasland changed the title cached_statements default value is incorrect sqlite3.connect parameter cached_statements default value is incorrect Sep 27, 2022
@erlend-aasland erlend-aasland added the 3.10 only security fixes label Sep 27, 2022
Repository owner moved this from In Progress to Done in sqlite3 issues Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erlend-aasland erlend-aasland

Labels
3.10 only security fixes docs Documentation in the Doc dir topic-sqlite3
Projects
sqlite3 issues
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[3.10] gh-97567: Fix cached_statements default value jiajunjie/cpython
4 participants
@pochmann @erlend-aasland @jiajunjie @AlexWaygood