Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default child watcher to PidfdChildWatcher on supported Linux versions #98023

Closed
kumaraditya303 opened this issue Oct 7, 2022 · 1 comment
Closed

Change default child watcher to PidfdChildWatcher on supported Linux versions #98023

kumaraditya303 opened this issue Oct 7, 2022 · 1 comment
Assignees
@kumaraditya303
Labels
3.12 bugs and security fixes topic-asyncio type-feature A feature request or enhancement

Comments

@kumaraditya303
Copy link
Contributor

kumaraditya303 commented Oct 7, 2022 •
edited
Loading

PidfdChildWatcher based on pidfd_open is the best child watcher implementation for Linux as it avoids race conditions and is most reliable of all of them. It requires Linux 5.3+ so this will be detected at runtime if it can be used and if so use this instead of ThreadedChildWatcher. asyncio will favor using PidfdChildWatcher over ThreadedChildWatcher in 3.12+ on systems which supports it.
@kumaraditya303 kumaraditya303 added type-feature A feature request or enhancement topic-asyncio 3.12 bugs and security fixes labels Oct 7, 2022
@kumaraditya303 kumaraditya303 moved this to Todo in asyncio Oct 7, 2022
@kumaraditya303 kumaraditya303 self-assigned this Oct 7, 2022
@bedevere-bot bedevere-bot mentioned this issue Oct 7, 2022
Merged
gvanrossum pushed a commit that referenced this issue Oct 8, 2022
@kumaraditya303
GH-98023: Change default child watcher to PidfdChildWatcher on suppor…
8ba9378 
…ted systems (#98024)
@gvanrossum
Copy link
Member

Thanks!

There's a little bit of possible cleanup -- the check whether os.pidfd_open() exists and works (can_use_pidfd()) is duplicated in Lib/test/test_asyncio/test_subprocess.py (as _has_pidfd_support). While can_use_pidfd() is not a documented or public API I think it's better to call it from the test code so there's only one copy to update if the check ever changes.

Repository owner moved this from Todo to Done in asyncio Oct 8, 2022
carljm added a commit to carljm/cpython that referenced this issue Oct 8, 2022
@carljm
Merge branch 'main' into typewatch
d67d6fd 
* main:
  pythongh-68686: Retire eptag ptag scripts (python#98064)
  pythongh-97922: Run the GC only on eval breaker (python#97920)
  GitHub Workflows security hardening (python#96492)
  Add `@ezio-melotti` as codeowner for `.github/`. (python#98079)
  pythongh-97913 Docs: Add walrus operator to the index (python#97921)
  [doc] Fix broken links to C extensions accelerating stdlib modules (python#96914)
  pythongh-97822: Fix http.server documentation reference to test() function (python#98027)
  pythongh-91052: Add PyDict_Unwatch for unwatching a dictionary (python#98055)
  pythonGH-98023: Change default child watcher to PidfdChildWatcher on supported systems (python#98024)
  pythonGH-94182: Run the PidfdChildWatcher on the running loop (python#94184)
carljm added a commit to carljm/cpython that referenced this issue Oct 9, 2022
@carljm
Merge branch 'main' into urllibnonet
132c32e 
* main: (5519 commits)
  Minor edits to the Descriptor HowTo Guide (pythonGH-24901)
  Fix link to Lifecycle of a Pull Request in CONTRIBUTING (python#98102)
  pythonGH-94597: deprecate `SafeChildWatcher`, `FastChildWatcher` and `MultiLoopChildWatcher` child watchers  (python#98089)
  Auto-cancel old builds when new commit pushed to branch (python#98009)
  pythongh-95011: Migrate syslog module to Argument Clinic (pythonGH-95012)
  pythongh-68686: Retire eptag ptag scripts (python#98064)
  pythongh-97922: Run the GC only on eval breaker (python#97920)
  GitHub Workflows security hardening (python#96492)
  Add `@ezio-melotti` as codeowner for `.github/`. (python#98079)
  pythongh-97913 Docs: Add walrus operator to the index (python#97921)
  [doc] Fix broken links to C extensions accelerating stdlib modules (python#96914)
  pythongh-97822: Fix http.server documentation reference to test() function (python#98027)
  pythongh-91052: Add PyDict_Unwatch for unwatching a dictionary (python#98055)
  pythonGH-98023: Change default child watcher to PidfdChildWatcher on supported systems (python#98024)
  pythonGH-94182: Run the PidfdChildWatcher on the running loop (python#94184)
  pythongh-92886: make test_ast pass with -O (assertions off) (pythonGH-98058)
  pythongh-92886: make test_coroutines pass with -O (assertions off) (pythonGH-98060)
  pythongh-57179: Add note on symlinks for os.walk (python#94799)
  pythongh-94808: Fix regex on exotic platforms (python#98036)
  pythongh-90085: Remove vestigial -t and -c timeit options (python#94941)
  ...
mpage pushed a commit to mpage/cpython that referenced this issue Oct 11, 2022
@kumaraditya303 @mpage
pythonGH-98023: Change default child watcher to PidfdChildWatcher on …
776f894 
…supported systems (python#98024)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kumaraditya303 kumaraditya303

Labels
3.12 bugs and security fixes topic-asyncio type-feature A feature request or enhancement
Projects
asyncio
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gvanrossum @kumaraditya303