Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_filter_to_company() in test_launcher fails due to py.ini #98414

Closed
eryksun opened this issue Oct 18, 2022 · 2 comments
Closed

test_filter_to_company() in test_launcher fails due to py.ini #98414

eryksun opened this issue Oct 18, 2022 · 2 comments
Assignees
@zooba
Labels
3.11 only security fixes 3.12 bugs and security fixes OS-windows type-bug An unexpected behavior, bug, or error

Comments

@eryksun
Copy link
Contributor

eryksun commented Oct 18, 2022

The test in test_filter_to_company() executes a dry run of the launcher with the argument "-V:PythonTestSuite/". The filter is incomplete, but the test expects the launcher to select "PythonTestSuite/3.100", with the command "X.Y.exe". In practice, however, a default version set in "py.ini" overrides an incomplete filter by company. I assume this is a bug in the launcher, that it's supposed to select the best match among the installations for the given company instead of using the default version. That's how it behaves if no default is set in "py.ini" or the "PY_PYTHON" environment variable.
@eryksun eryksun added type-bug An unexpected behavior, bug, or error OS-windows 3.11 only security fixes 3.12 bugs and security fixes labels Oct 18, 2022
@zooba
Copy link
Member

zooba commented Oct 19, 2022

Yes correct, it shouldn't use the default value in this case.

@bedevere-bot bedevere-bot mentioned this issue Oct 19, 2022
Merged
zooba added a commit to zooba/cpython that referenced this issue Oct 19, 2022
@zooba
pythongh-98414: py.exe launcher does not use defaults for -V:company/…
8a39685 
… option
zooba added a commit that referenced this issue Oct 19, 2022
@zooba
gh-98414: py.exe launcher does not use defaults for -V:company/ option (
4bd63f6 
GH-98460)
@bedevere-bot bedevere-bot mentioned this issue Oct 19, 2022
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 19, 2022
@zooba @miss-islington
pythongh-98414: py.exe launcher does not use defaults for -V:company/…
b650b42 
… option (pythonGH-98460)

(cherry picked from commit 4bd63f6)

Co-authored-by: Steve Dower <steve.dower@python.org>
miss-islington added a commit that referenced this issue Oct 19, 2022
@miss-islington @zooba
gh-98414: py.exe launcher does not use defaults for -V:company/ option (
0b71dad 
GH-98460)

(cherry picked from commit 4bd63f6)

Co-authored-by: Steve Dower <steve.dower@python.org>
carljm added a commit to carljm/cpython that referenced this issue Oct 20, 2022
@carljm
Merge branch 'main' into typewatch
8bba5da 
* main: (40 commits)
  pythongh-98461: Fix source location in comprehensions bytecode (pythonGH-98464)
  pythongh-98421: Clean Up PyObject_Print (pythonGH-98422)
  pythongh-98360: multiprocessing now spawns children on Windows with correct argv[0] in virtual environments (pythonGH-98462)
  CODEOWNERS: Become a typing code owner (python#98480)
  [doc] Improve logging cookbook example. (pythonGH-98481)
  Add more tkinter.Canvas tests (pythonGH-98475)
  pythongh-95023: Added os.setns and os.unshare functions (python#95046)
  pythonGH-98363: Presize the list for batched() (pythonGH-98419)
  pythongh-98374: Suppress ImportError for invalid query for help() command. (pythongh-98450)
  typing tests: `_overload_dummy` raises `NotImplementedError`, not `RuntimeError` (python#98351)
  pythongh-98354: Add unicode check for 'name' attribute in _imp_create_builtin (pythonGH-98412)
  pythongh-98257: Make _PyEval_SetTrace() reentrant (python#98258)
  pythongh-98414: py.exe launcher does not use defaults for -V:company/ option (pythonGH-98460)
  pythongh-98417: Store int_max_str_digits on the Interpreter State (pythonGH-98418)
  Doc: Remove title text from internal links (python#98409)
  [doc] Refresh the venv introduction documentation, and correct the statement about VIRTUAL_ENV (pythonGH-98350)
  Docs: Bump sphinx-lint and fix unbalanced inline literal markup (python#98441)
  pythongh-92886: Replace assertion statements in `handlers.BaseHandler` to support running with optimizations (`-O`) (pythonGH-93231)
  pythongh-92886: Fix tests that fail when running with optimizations (`-O`) in `_test_multiprocessing.py` (pythonGH-93233)
  pythongh-92886: Fix tests that fail when running with optimizations (`-O`) in `test_py_compile.py` (pythonGH-93235)
  ...
pablogsal pushed a commit that referenced this issue Oct 22, 2022
@miss-islington @zooba @pablogsal
gh-98414: py.exe launcher does not use defaults for -V:company/ option (
fc12762 
GH-98460)

(cherry picked from commit 4bd63f6)

Co-authored-by: Steve Dower <steve.dower@python.org>
@hauntsaninja
Copy link
Contributor

Thanks, looks like this was completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zooba zooba

Labels
3.11 only security fixes 3.12 bugs and security fixes OS-windows type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eryksun @zooba @hauntsaninja