Skip to content

CI: "Tests / Check if generated files are up to date" failed #99016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
serhiy-storchaka opened this issue Nov 2, 2022 · 1 comment
Closed

CI: "Tests / Check if generated files are up to date" failed #99016

serhiy-storchaka opened this issue Nov 2, 2022 · 1 comment
Labels
3.11 only security fixes 3.12 only security fixes build The build process and cross-build type-bug An unexpected behavior, bug, or error

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Nov 2, 2022 •
edited by bedevere-bot
Loading

CI: "Tests / Check if generated files are up to date" failed because some source generating scripts are not compatible with Python 3.8.

There is no reason to not make them compatible with Python 3.8.
@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error build The build process and cross-build labels Nov 2, 2022
@JelleZijlstra
Copy link
Member

I fixed this in #98988: we were incorrectly skipping 3.11. However, we should probably also make the script compatible with 3.8.

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Nov 2, 2022
@serhiy-storchaka
pythongh-99016: Make build scripts compatible with Python 3.8
2649c25
@bedevere-bot bedevere-bot mentioned this issue Nov 2, 2022
Merged
serhiy-storchaka added a commit that referenced this issue Nov 2, 2022
@serhiy-storchaka
gh-99016: Make build scripts compatible with Python 3.8 (GH-99017)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
f520d72
@bedevere-bot bedevere-bot mentioned this issue Nov 22, 2022
Merged
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Nov 22, 2022
@serhiy-storchaka
[3.11] pythongh-99016: Make build scripts compatible with Python 3.8 (p…
581e23a 
…ythonGH-99017).

(cherry picked from commit f520d72)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this issue Nov 22, 2022
@serhiy-storchaka
[3.11] gh-99016: Make build scripts compatible with Python 3.8 (GH-99017
49f2eee 
). (GH-99693)

(cherry picked from commit f520d72)
@serhiy-storchaka serhiy-storchaka added 3.11 only security fixes 3.12 only security fixes labels Nov 22, 2022
@erlend-aasland erlend-aasland mentioned this issue May 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.11 only security fixes 3.12 only security fixes build The build process and cross-build type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JelleZijlstra @serhiy-storchaka @erlend-aasland