Skip to content

Make sure regen-cases are in regen-all #99048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sobolevn opened this issue Nov 3, 2022 · 0 comments
Closed

Make sure regen-cases are in regen-all #99048

sobolevn opened this issue Nov 3, 2022 · 0 comments
Assignees
Labels
build The build process and cross-build tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented Nov 3, 2022

regen-cases introduced in #98830 currently does not check if cases are correctly regenerate in our CI.

See:

- name: Build CPython
run: |
# Deepfreeze will usually cause global objects to be added or removed,
# so we run it before regen-global-objects gets rum (in regen-all).
make regen-deepfreeze
make -j4 regen-all
make regen-stdlib-module-names
- name: Check for changes
run: |
git add -u
changes=$(git status --porcelain)
# Check for changes in regenerated files

Sorry, I was not quick enough to submit this in review :)
PR is on its way.

@sobolevn sobolevn added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir build The build process and cross-build labels Nov 3, 2022
@sobolevn sobolevn self-assigned this Nov 3, 2022
sobolevn added a commit to sobolevn/cpython that referenced this issue Nov 3, 2022
@sobolevn sobolevn closed this as completed Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build The build process and cross-build tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

1 participant