Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-99955: standardize return values of functions in compiler's code-gen #100010

Merged
merged 96 commits into from
Dec 12, 2022
Merged

gh-99955: standardize return values of functions in compiler's code-gen #100010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
96 commits
Select commit Hold shift + click to select a range
97d929f
compiler_setup returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
0e14141
cfg_builder_init returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
5d81ad0
compiler_set_qualname returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
6d56a1b
basicblock_addop returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
3b87215
cfg_builder_addop returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
829ed2d
cfg_builder_addop_noarg returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
8be8f0b
cfg_builder_addop_i returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
9374ac0
compiler_addop_name returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
9d21d49
compiler_addop_o and compiler_addop_load_const returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
a67c612
cfg_builder_addop_j returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
844b78f
prepend macros with _
iritkatriel Dec 4, 2022
4ca4b8c
add new versions of the macros (not used yet)
iritkatriel Dec 4, 2022
9baeb63
compiler_enter_scope returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
566acc5
find_add returns bool
iritkatriel Dec 4, 2022
93287a1
compiler_push_fblock returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
8515380
compiler_call_exit_with_nones returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
13583a3
pop_except_and_reraise returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
1fd574a
compiler_add_yield_from returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
a3d5cad
compiler_unwind_fblock returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
6fe5dd7
compiler_unwind_fblock_stack returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
297a0d6
compiler_body returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
c504cd3
compiler_codegen returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
b6028e2
compiler_make_closure returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
19235f7
compiler_decorators and compiler_apply_decorators return SUCCESS/ERROR
iritkatriel Dec 4, 2022
9d93635
compiler_visit_kwonlydefaults returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
dfbe826
forbidden_name returns bool
iritkatriel Dec 4, 2022
9757b0d
compiler_check_debug_one_arg, compiler_check_debug_args, compiler_che…
iritkatriel Dec 4, 2022
151e8f0
insert_instruction, wrap_in_stopiteration_handler return SUCCESS/ERROR
iritkatriel Dec 4, 2022
1409c3e
compiler_class returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
d1a28e4
compiler_return returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
15b73da
compiler_augassign return SUCCESS/ERROR
iritkatriel Dec 4, 2022
40615da
compiler_annassign returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
90bb804
compiler_for returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
42dca92
compiler_while returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
fdf615f
compiler_if returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
99a7257
compiler_try_finally returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
0902cf1
compiler_try_except returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
2680b56
compiler_try_star_finally, compiler_try_star_except return SUCCESS/ERROR
iritkatriel Dec 4, 2022
6136f33
compiler_try, compiler_try_star return SUCCESS/ERROR
iritkatriel Dec 4, 2022
73d8b72
compiler_assert returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
6966b26
compiler_import, compiler_import_as return SUCCESS/ERROR
iritkatriel Dec 4, 2022
1cdf83b
compiler_from_import, compiler_break return SUCCESS/ERROR
iritkatriel Dec 4, 2022
229d6fd
compiler_continue, compiler_with, compiler_async_with return SUCCESS/…
iritkatriel Dec 4, 2022
f8b658e
compiler_stmt_expr, compiler_async_for return SUCCESS/ERROR
iritkatriel Dec 4, 2022
5d8f93b
ensure_fail_pop return SUCCESS/ERROR
iritkatriel Dec 4, 2022
71e13c2
jump_to_fail_pop return SUCCESS/ERROR
iritkatriel Dec 4, 2022
4f10612
emit_and_reset_fail_pop, compiler_error_duplicate_store return SUCCES…
iritkatriel Dec 4, 2022
a5d017d
pattern_helper_rotate return SUCCESS/ERROR
iritkatriel Dec 4, 2022
cbb63b0
pattern_helper_store_name returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
06ba665
pattern_unpack_helper returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
0b84a46
pattern_helper_sequence_unpack returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
c8acddb
pattern_helper_sequence_subscr, compiler_pattern_subpattern return SU…
iritkatriel Dec 4, 2022
44d5452
compiler_pattern_as, compiler_pattern_star return SUCCESS/ERROR
iritkatriel Dec 4, 2022
77d8b27
compiler_pattern_class, validate_kwd_attrs return SUCCESS/ERROR
iritkatriel Dec 4, 2022
2e23b8f
compiler_pattern_mapping returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
31bc6cd
compiler_pattern_or returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
42c36cf
compiler_pattern_sequence returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
a0a19dc
compiler_pattern_value, compiler_pattern_singleton returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
ac78f3c
compiler_pattern return SUCCESS/ERROR
iritkatriel Dec 4, 2022
57bffde
compiler_match, compiler_match_inner return SUCCESS/ERROR
iritkatriel Dec 4, 2022
855cdde
compiler_function return SUCCESS/ERROR
iritkatriel Dec 4, 2022
45028d5
compiler_call_helper returns SUCCESS/ERROR
iritkatriel Dec 4, 2022
5843200
check_caller, compiler_call RETURN SUCCESS/ERROR
iritkatriel Dec 4, 2022
7611a97
check_compare, compiler_addcompare return SUCCESS/ERROR
iritkatriel Dec 4, 2022
3122826
compiler_ifexp, compiler_boolop, unpack_helper, assignment_helper ret…
iritkatriel Dec 4, 2022
46e7471
addop_yield, addop_binary compiler_addcompare return SUCCESS/ERROR
iritkatriel Dec 4, 2022
a31d078
compiler_with_except_finish return SUCCESS/ERROR
iritkatriel Dec 4, 2022
95a47a6
compiler_lambda return SUCCESS/ERROR
iritkatriel Dec 4, 2022
56178d3
compiler_visit_defaults return SUCCESS/ERROR
iritkatriel Dec 4, 2022
0c6687d
compiler_visit_*annotation(s) return SUCCESS/ERROR
iritkatriel Dec 4, 2022
0ee940f
compiler_comprehension_* return SUCCESS/ERROR
iritkatriel Dec 5, 2022
6a37392
starunpack_helper return SUCCESS/ERROR
iritkatriel Dec 5, 2022
40cb86c
compiler_list, compiler_tuple, compiler_subdict, compiler_dict return…
iritkatriel Dec 5, 2022
b8cd5a3
are_all_items_const returns bool
iritkatriel Dec 5, 2022
1bc7cc6
compiler_comprehension/listcomp/dictcomp/setcomp/genexp return SUCCES…
iritkatriel Dec 5, 2022
93af682
compiler_jump_if returns SUCCESS/ERROR
iritkatriel Dec 5, 2022
13b6f8d
maybe_optimize_method_call, compiler_call_simple_kw_helper return SUC…
iritkatriel Dec 5, 2022
3bfb5d7
compiler_joined_str, compiler_formatted_value return SUCCESS/ERROR
iritkatriel Dec 5, 2022
6d40de7
compiler_slice returns SUCCESS/ERROR
iritkatriel Dec 5, 2022
49da813
compiler_nameop returns SUCCESS/ERROR
iritkatriel Dec 5, 2022
adea67e
compiler_subscript and helpers return SUCCES/ERROR
iritkatriel Dec 5, 2022
40f7d15
annotations related functions return SUCCESS/ERROR
iritkatriel Dec 5, 2022
07756b4
compiler_subkwargs return SUCCESS/ERROR
iritkatriel Dec 5, 2022
45d26ef
visitor functions return SUCCESS/ERROR
iritkatriel Dec 5, 2022
d5b624b
compiler_error returns ERROR
iritkatriel Dec 5, 2022
ef1001c
compiler_warn returns SUCCESS/ERROR
iritkatriel Dec 5, 2022
e1a5414
use RETURN_IF_ERROR in a few places
iritkatriel Dec 5, 2022
e2b6368
minor tweaks
iritkatriel Dec 5, 2022
dad4799
reduce diff, revert error
iritkatriel Dec 5, 2022
730f5fd
Merge remote-tracking branch 'upstream/main' into return_values
iritkatriel Dec 5, 2022
137a9b0
Merge branch 'main' into return_values
iritkatriel Dec 12, 2022
9c7d675
📜🤖 Added by blurb_it.
blurb-it[bot] Dec 12, 2022
4271c43
Remove unnecessary ()
iritkatriel Dec 12, 2022
48802dc
-1 --> ERROR
iritkatriel Dec 12, 2022
77db056
Merge branch 'main' into return_values
iritkatriel Dec 12, 2022
a47b482
whitespace
iritkatriel Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core and Builtins/2022-12-12-11-27-54.gh-issue-99955.Ix5Rrg.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Internal compiler functions (in compile.c) now consistently return -1 on error and 0 on success.
Loading