Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-100131: Add optional delete parameter to tempfile.TemporaryDirectory() #100132

Merged
merged 9 commits into from
Mar 24, 2023
Merged

gh-100131: Add optional delete parameter to tempfile.TemporaryDirectory() #100132

merged 9 commits into from
Mar 24, 2023

Conversation

JakobDev
Copy link
Contributor

@JakobDev JakobDev commented Dec 9, 2022 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Dec 9, 2022
Closed
@netlify
Copy link

netlify bot commented Dec 9, 2022 •
edited
Loading

✅ Deploy Preview for python-cpython-preview canceled.

Name Link
🔨 Latest commit 31a4966
🔍 Latest deploy log https://app.netlify.com/sites/python-cpython-preview/deploys/63931a5ed081210008e5461a

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Dec 9, 2022 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@CAM-Gerlach CAM-Gerlach mentioned this pull request Mar 19, 2023
Closed
zware
zware reviewed Mar 20, 2023
View reviewed changes
Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch @JakobDev! This looks good, but incomplete: we'll need to add tests and documentation for this change.

@JakobDev
Copy link
Contributor Author

test and documentation have now been added

@arhadthedev arhadthedev requested a review from zware March 22, 2023 11:36
@gpshead
Copy link
Member

gpshead commented Mar 23, 2023

Closing per the discussion on the issue as we don't need this.

@gpshead gpshead closed this Mar 23, 2023
@AlexWaygood

This comment was marked as duplicate.

Sign in to view
@gpshead gpshead reopened this Mar 24, 2023
@gpshead gpshead self-assigned this Mar 24, 2023
@gpshead gpshead merged commit 64cb1a4 into python:main Mar 24, 2023
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
@JakobDev @gpshead @Fidget-Spinner
pythongh-100131: Add optional delete parameter to tempfile.TemporaryD…
2812212 
…irectory() (python#100132)

Add optional delete parameter to tempfile.TemporaryDirectory().

Co-authored-by: Gregory P. Smith <greg@krypto.org>
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@JakobDev @gpshead @warsaw
pythongh-100131: Add optional delete parameter to tempfile.TemporaryD…
b427155 
…irectory() (python#100132)

Add optional delete parameter to tempfile.TemporaryDirectory().

Co-authored-by: Gregory P. Smith <greg@krypto.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zware zware Awaiting requested review from zware

Assignees

@gpshead gpshead

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JakobDev @bedevere-bot @gpshead @AlexWaygood @zware