-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
gh-100165: Add BINARY_OP_AND_INT for integer & operation. #100166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for python-cpython-preview canceled.
|
Stats
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks Dong-hee.
Misc/NEWS.d/next/Core and Builtins/2022-12-11-13-22-59.gh-issue-100165.GE1Iui.rst
Outdated
Show resolved
Hide resolved
…e-100165.GE1Iui.rst Co-authored-by: Ken Jin <kenjin@python.org>
Let's wait for Mark before merging this. |
Does this improve the pyperformance results at all? If not, I'd suggest that we take a different approach (discussed with @markshannon this morning): Rather than try to add more and more non-performance-improving Once we get that working, the mechanism could be extended to cache the results of recent operator lookups (like the method cache) or even allow extensions like NumPy to register custom specializations. I'd be happy to run the pyperformance numbers for you if you want. I also have a small hunch that the pyperformance suite over-represents how often integer |
Also, see our previous rejection of this idea: #94109. |
Ah, I agree that what we have to go.
Same result with Mark's last running: #94109 (comment) Well, I agree that this PR is not worth to merge. |
According to stats, BINARY_AND_INT will cover 50.7% of failures.