gh-100305: Deemphasize that ast.literal_eval is safe in eval documentation
#100326
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slateny
reviewed
Dec 20, 2022
Doc/library/functions.rst
Outdated
| @@ -554,8 +554,9 @@ are always available. They are listed here in alphabetical order. | |||
| If the given source is a string, then leading and trailing spaces and tabs | |||
| are stripped. | |||
|
|
|||
| See :func:`ast.literal_eval` for a function that can safely evaluate strings | |||
| with expressions containing only literals. | |||
| .. versionchanged:: 3.11 | |||
There was a problem hiding this comment.
I'm not so sure about saying 'version changed', as it seems to imply that only 3.11 has the change, but 3.10 also has it as it was backported (see PR). I'd say it's okay to just keep the original format and adjust the wording.
slateny
changed the title
ast.literal_eval is still referred to as safe by the documentation for evalast.literal_eval is safe in eval documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gh-100305: Changed the doc referencing to
literal_evalin eval as it was misleading asliteral_evalwas said safe