Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-100348: asyncio._SelectorSocketTransport: free cyclic reference on close() #100349

Merged
merged 3 commits into from
Dec 20, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Lib/asyncio/selector_events.py
Original file line number Diff line number Diff line change
Expand Up @@ -1133,6 +1133,10 @@ def _make_empty_waiter(self):
def _reset_empty_waiter(self):
self._empty_waiter = None

def close(self):
self._read_ready_cb = None
super().close()


class _SelectorDatagramTransport(_SelectorTransport, transports.DatagramTransport):

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix ref cycle in :class:`!asyncio._SelectorSocketTransport` by removing ``_read_ready_cb`` in ``close``.