Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-99953: Purge mention of numeric param style from sqlite3 docs #100630

Merged

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Dec 30, 2022

The PEP-249 numeric style has never been supported.
@erlend-aasland
Copy link
Contributor Author

cc. @zzzeek

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, pending potential resolution of the clarification @zzzeek mentioned (that I lack the subject matter expertise to otherwise comment on).

Doc/library/sqlite3.rst Show resolved Hide resolved
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@erlend-aasland erlend-aasland deleted the no-numeric-style-for-you branch January 1, 2023 22:26
@bedevere-bot
Copy link

GH-100669 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jan 1, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 1, 2023
pythonGH-100630)

The PEP-249 numeric style has never been supported by sqlite3.
(cherry picked from commit b7a68ab)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

GH-100670 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 1, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 1, 2023
pythonGH-100630)

The PEP-249 numeric style has never been supported by sqlite3.
(cherry picked from commit b7a68ab)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
miss-islington added a commit that referenced this pull request Jan 1, 2023
…100630)

The PEP-249 numeric style has never been supported by sqlite3.
(cherry picked from commit b7a68ab)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
miss-islington added a commit that referenced this pull request Jan 1, 2023
…100630)

The PEP-249 numeric style has never been supported by sqlite3.
(cherry picked from commit b7a68ab)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants