Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-100689: Revert "bpo-41798: pyexpat: Allocate the expat_CAPI on the… #100745

Merged
merged 8 commits into from
Jan 8, 2023
Merged

gh-100689: Revert "bpo-41798: pyexpat: Allocate the expat_CAPI on the… #100745

merged 8 commits into from
Jan 8, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jan 4, 2023 •
edited by bedevere-bot
Loading

… heap memory (GH-24061)"

This reverts commit 7c83eaa.

This would need to be back-ported to 3.10 and 3.11

@bedevere-bot bedevere-bot mentioned this pull request Jan 4, 2023
Closed
@sobolevn sobolevn added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes skip news labels Jan 4, 2023
kumaraditya303
kumaraditya303 requested changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a news entry as this is a bug fix.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!

@sobolevn
Copy link
Member Author

sobolevn commented Jan 4, 2023

Done! I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@kumaraditya303: please review the changes made to this pull request.

@kumaraditya303 kumaraditya303 added the type-crash A hard crash of the interpreter, possibly with a core dump label Jan 4, 2023
@SoulReaverFan
Copy link

Thank you so much for your work on fixing this issue. It is very much appreciated 👍

@kumaraditya303 kumaraditya303 merged commit b034fd3 into python:main Jan 8, 2023
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-100846 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jan 8, 2023
@bedevere-bot
Copy link

GH-100847 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 8, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 8, 2023
@sobolevn @miss-islington
pythongh-100689: Revert "bpo-41798: pyexpat: Allocate the expat_CAPI …
a65e93e 
…on the heap memory (pythonGH-24061)" (pythonGH-100745)

* pythongh-100689: Revert "bpo-41798: pyexpat: Allocate the expat_CAPI on the heap memory (pythonGH-24061)"

This reverts commit 7c83eaa.
(cherry picked from commit b034fd3)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 8, 2023
@sobolevn @miss-islington
pythongh-100689: Revert "bpo-41798: pyexpat: Allocate the expat_CAPI …
30b8ac2 
…on the heap memory (pythonGH-24061)" (pythonGH-100745)

* pythongh-100689: Revert "bpo-41798: pyexpat: Allocate the expat_CAPI on the heap memory (pythonGH-24061)"

This reverts commit 7c83eaa.
(cherry picked from commit b034fd3)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this pull request Jan 8, 2023
@miss-islington @sobolevn
gh-100689: Revert "bpo-41798: pyexpat: Allocate the expat_CAPI on the…
6c7e32f 
… heap memory (GH-24061)" (GH-100745)

* gh-100689: Revert "bpo-41798: pyexpat: Allocate the expat_CAPI on the heap memory (GH-24061)"

This reverts commit 7c83eaa.
(cherry picked from commit b034fd3)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
kumaraditya303 pushed a commit that referenced this pull request Jan 8, 2023
@miss-islington @sobolevn
[3.10] gh-100689: Revert "bpo-41798: pyexpat: Allocate the expat_CAPI…
0e00bce 
… on the heap memory (GH-24061)" (GH-100745) (#100847)

gh-100689: Revert "bpo-41798: pyexpat: Allocate the expat_CAPI on the heap memory (GH-24061)" (GH-100745)

* gh-100689: Revert "bpo-41798: pyexpat: Allocate the expat_CAPI on the heap memory (GH-24061)"

This reverts commit 7c83eaa.
(cherry picked from commit b034fd3)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees
No one assigned
Labels
release-blocker type-crash A hard crash of the interpreter, possibly with a core dump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sobolevn @bedevere-bot @SoulReaverFan @miss-islington @erlend-aasland @kumaraditya303