Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-100247: Fix py.exe launcher not using entire shebang command for finding custom commands #100944

Merged
merged 3 commits into from
Jan 13, 2023
Merged

gh-100247: Fix py.exe launcher not using entire shebang command for finding custom commands #100944

merged 3 commits into from
Jan 13, 2023

Conversation

zooba
Copy link
Member

@zooba zooba commented Jan 11, 2023 •
edited by bedevere-bot
Loading

@zooba zooba requested a review from a team as a code owner January 11, 2023 14:47
@bedevere-bot bedevere-bot mentioned this pull request Jan 11, 2023
Closed
@zooba
Copy link
Member Author

zooba commented Jan 12, 2023

Added some docs to cover the command configuration, though I'm not thrilled with them. Open to any suggestions on better examples - my only condition is that I don't want to draw too much attention to this. It works, and we'll keep it working, but it's not meant to be a major feature

@zooba
Copy link
Member Author

zooba commented Jan 13, 2023

On re-reading, I don't hate the example quite so much, so we'll get the fix in. Docs can be changed later

@zooba zooba merged commit 468c3bf into python:main Jan 13, 2023
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@zooba zooba deleted the gh-100247 branch January 13, 2023 11:49
@bedevere-bot
Copy link

GH-101012 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jan 13, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 13, 2023
@zooba @miss-islington
pythongh-100247: Fix py.exe launcher not using entire shebang command…
799fec9 
… for finding custom commands (pythonGH-100944)

(cherry picked from commit 468c3bf)

Co-authored-by: Steve Dower <steve.dower@python.org>
miss-islington added a commit that referenced this pull request Jan 13, 2023
@miss-islington @zooba
gh-100247: Fix py.exe launcher not using entire shebang command for f…
6492492 
…inding custom commands (GH-100944)

(cherry picked from commit 468c3bf)

Co-authored-by: Steve Dower <steve.dower@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
OS-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zooba @miss-islington @bedevere-bot