Skip to content

gh-86610: Use attribute directive in docs for pathlib.PurePath #101114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

barneygale
Copy link
Contributor

@barneygale barneygale commented Jan 18, 2023

Change 'data' directives to 'attribute', and 'data' roles to 'attr'.

'data' should only be used for module-level data: https://www.sphinx-doc.org/en/master/usage/restructuredtext/domains.html#directive-py-data

@barneygale barneygale added docs Documentation in the Doc dir skip news 3.11 only security fixes 3.10 only security fixes 3.12 only security fixes labels Jan 18, 2023
@barneygale barneygale linked an issue Jan 18, 2023 that may be closed by this pull request
@barneygale barneygale added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes and removed 3.11 only security fixes 3.10 only security fixes 3.12 only security fixes labels Jan 18, 2023
@ambv ambv merged commit 01093b8 into python:main Jan 20, 2023
@miss-islington
Copy link
Contributor

Thanks @barneygale for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2023
…ythonGH-101114)

(cherry picked from commit 01093b8)

Co-authored-by: Barney Gale <barney.gale@gmail.com>
@bedevere-bot
Copy link

GH-101205 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jan 20, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2023
…ythonGH-101114)

(cherry picked from commit 01093b8)

Co-authored-by: Barney Gale <barney.gale@gmail.com>
@bedevere-bot
Copy link

GH-101206 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 20, 2023
ambv pushed a commit that referenced this pull request Jan 20, 2023
…GH-101114) (#101205)

(cherry picked from commit 01093b8)

Co-authored-by: Barney Gale <barney.gale@gmail.com>
ambv pushed a commit that referenced this pull request Jan 20, 2023
…GH-101114) (#101206)

(cherry picked from commit 01093b8)

Co-authored-by: Barney Gale <barney.gale@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attributes of pathlib classes are not indexed in Windows help file
4 participants