Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in pystate.c file #101348

Merged
merged 3 commits into from
Jan 26, 2023
Merged

Conversation

vitaldmit
Copy link
Contributor

@vitaldmit vitaldmit commented Jan 26, 2023

Fixed typos in pystate.c file

@ghost
Copy link

ghost commented Jan 26, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@vitaldmit vitaldmit changed the title Fix typo in pystate.c file mus -> must Fix typo in pystate.c file Jan 26, 2023
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@vitaldmit vitaldmit changed the title Fix typo in pystate.c file Fix typos in pystate.c file Jan 26, 2023
@vitaldmit
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from hugovk January 26, 2023 18:08
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@hugovk hugovk added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jan 26, 2023
@hauntsaninja hauntsaninja merged commit 37f15a5 into python:main Jan 26, 2023
@miss-islington
Copy link
Contributor

Thanks @vitaldmit for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @vitaldmit and @hauntsaninja, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 37f15a5efab847b8aca47981ab596e9c36445bf7 3.11

@miss-islington
Copy link
Contributor

Sorry @vitaldmit and @hauntsaninja, I had trouble checking out the 3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 37f15a5efab847b8aca47981ab596e9c36445bf7 3.10

@hauntsaninja
Copy link
Contributor

The main reason to backport would be to avoid future merge conflicts. There are a bunch of changes here, so I'm not planning on backporting this.

@hauntsaninja hauntsaninja removed their assignment Jan 26, 2023
@hauntsaninja hauntsaninja removed needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jan 26, 2023
mdboom pushed a commit to mdboom/cpython that referenced this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants