Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-101313: add -h and --help arguments to the webbrowser module #101374

Merged
merged 5 commits into from
Mar 22, 2023
Merged

gh-101313: add -h and --help arguments to the webbrowser module #101374

merged 5 commits into from
Mar 22, 2023

Conversation

Icelain
Copy link
Contributor

@Icelain Icelain commented Jan 27, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Jan 27, 2023
Closed
@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Jan 27, 2023 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@iritkatriel iritkatriel changed the title gh-101313: add -h and --help arguments gh-101313: add -h and --help arguments to the webbrowser module Jan 29, 2023
@arhadthedev arhadthedev added the stdlib Python modules in the Lib dir label Feb 12, 2023
@corona10 corona10 self-assigned this Feb 22, 2023
corona10
corona10 reviewed Feb 22, 2023
View reviewed changes
@Icelain @corona10
Update Lib/webbrowser.py
d9346d1 
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
Icelain
Icelain commented Feb 25, 2023
View reviewed changes
Copy link
Contributor Author

@Icelain Icelain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the suggested change :)

@Icelain Icelain requested a review from corona10 March 21, 2023 14:27
corona10
corona10 approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for the hardwork!

@corona10 corona10 merged commit 3d7eb66 into python:main Mar 22, 2023
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
@Icelain @Fidget-Spinner
pythongh-101313: Add -h and --help arguments to the webbrowser module (…
f0e9319 
…pythongh-101374)
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@Icelain @warsaw
pythongh-101313: Add -h and --help arguments to the webbrowser module (…
d9c2c9a 
…pythongh-101374)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

Assignees

@corona10 corona10

Labels
stdlib Python modules in the Lib dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Icelain @bedevere-bot @corona10 @arhadthedev