Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-89381: Fix invalid signatures of math/cmath.log #101404

Merged
merged 3 commits into from
Jan 29, 2023
Merged

gh-89381: Fix invalid signatures of math/cmath.log #101404

merged 3 commits into from
Jan 29, 2023

Conversation

skirpichev
Copy link
Member

@skirpichev skirpichev commented Jan 29, 2023 •
edited
Loading

@bedevere-bot bedevere-bot mentioned this pull request Jan 29, 2023
Closed
@skirpichev skirpichev mentioned this pull request Jan 29, 2023
Closed
@skirpichev
Copy link
Member Author

skirpichev commented Jan 29, 2023 •
edited
Loading

Probably, changes in the math.rst could be reverted too (like 1efcf49 does) reworded like "If the base is not specified returns the natural logarithm (base e) of x.".

BTW, I would appreciate Raymond's review too.

@mdickinson
Copy link
Member

Yes, I'd suggest losing the or is None in the math.rst, too. Other than that, this LGTM.

mdickinson
mdickinson reviewed Jan 29, 2023
View reviewed changes
mdickinson
mdickinson approved these changes Jan 29, 2023
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skirpichev
Copy link
Member Author

Thanks for review and I'm sorry for the closed pr.

hauntsaninja
hauntsaninja approved these changes Jan 29, 2023
View reviewed changes
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for sticking with this!

@hauntsaninja hauntsaninja merged commit 0ef92d9 into python:main Jan 29, 2023
@skirpichev skirpichev deleted the fix-89381 branch January 29, 2023 23:55
mdboom pushed a commit to mdboom/cpython that referenced this pull request Jan 31, 2023
@skirpichev @mdboom
pythongh-89381: Fix invalid signatures of math/cmath.log (python#101404)
48d51e5
mdickinson added a commit to mdickinson/cpython that referenced this pull request Feb 5, 2023
@mdickinson
Revert "pythongh-89381: Fix invalid signatures of math/cmath.log (pyt…
d1daa27 
…hon#101404)"

This reverts commit 0ef92d9.
mdickinson added a commit that referenced this pull request Feb 5, 2023
@mdickinson
Revert "gh-89381: Fix invalid signatures of math/cmath.log (#101404)" (…
0672a6c 
…#101580)

This reverts commit 0ef92d9.
skirpichev added a commit to skirpichev/cpython that referenced this pull request Feb 6, 2023
@skirpichev
pythongh-89381: Fix invalid signatures of math/cmath.log (python#101404)
5a8d031 
Restored 0ef92d9 after reversion in python#101580
@skirpichev
Copy link
Member Author

Restored in #101593

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdickinson mdickinson mdickinson approved these changes

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skirpichev @mdickinson @hauntsaninja @bedevere-bot