bpo-35086: Fix tkinter docs A Simple Hello World Program #10160
Conversation
Application class does not hold onto the master Tk() instance as a class attribute.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
|
Not sure why it says my CLA is not signed - I submitted earlier today. Regarding no news entry: I did not feel this change was significant enough to be reflected in Doc/whatsnew |
|
Thanks @NuclearLemon for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7. |
…nGH-10160) The root widget was accessed as a global variable in the Application's method. (cherry picked from commit a80af77) Co-authored-by: Daniel Lovell <lovell.daniel92@gmail.com>
|
GH-10241 is a backport of this pull request to the 3.7 branch. |
…nGH-10160) The root widget was accessed as a global variable in the Application's method. (cherry picked from commit a80af77) Co-authored-by: Daniel Lovell <lovell.daniel92@gmail.com>
|
GH-10242 is a backport of this pull request to the 3.6 branch. |
|
Sorry, @NuclearLemon and @serhiy-storchaka, I could not cleanly backport this to |
) The root widget was accessed as a global variable in the Application's method. (cherry picked from commit a80af77) Co-authored-by: Daniel Lovell <lovell.daniel92@gmail.com>
) The root widget was accessed as a global variable in the Application's method. (cherry picked from commit a80af77) Co-authored-by: Daniel Lovell <lovell.daniel92@gmail.com>
Application class does not hold onto the master Tk() instance as a class attribute. This is a good practice, and newcomers to tkinter would likely have trouble closing the window without this since root will almost never be in the global namespace.
https://bugs.python.org/issue35086