-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-97696: DRAFT asyncio eager tasks factory prototype #101613
Closed
Closed
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
1ea845c
Copy GH-98137, make some changes, add benchmarking script, trying to …
itamaro de6d910
asyncio runner takes optional task factory arg
itamaro 56610e7
don't coro.send if the event loop is not running (yet)
itamaro 34082a7
modify async tree script to support eager factory
itamaro ce5beaf
don't over-count tasks that yield result immediately
itamaro 38d7b0b
handle task._source_traceback in eager task factory
itamaro 6afbaab
stop checking for eager factory in taskgroups
itamaro a6e68bc
refactor async tree benchmark to work with TaskGroup or gather depend…
itamaro 464bd49
restore C task
itamaro ac26ad6
yield_result -> coro_result
itamaro ae2dcf3
Support `coro_result` in Task C impl
itamaro 9794715
Merge branch 'main' into asyncio-eager-tasks-playground
itamaro 0b447b0
Address Dino's review comments
itamaro f2748e2
passthrough coro_result from custom constructor only if it is set
itamaro 61ac5d0
add != NULL assertion on step2 result
itamaro cbd14fb
Merge branch 'main' into asyncio-eager-tasks-playground
itamaro 3503337
fix result refcnting in task_step_handle_result_impl
itamaro 49c0e89
Add eager task factory tests
itamaro 8a5229a
cleanup eager task factory tests
itamaro d1e5fd1
add news blurb
itamaro 580fb1f
Merge branch 'main' into asyncio-eager-tasks-playground
itamaro 6284c41
apply patchcheck fixes in asyncio.tasks
itamaro 34123a7
regenerate clinic
itamaro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need a separate
task_factory
here? Ultimately this is just influencing the loop after it's created, couldn't that be rolled into the existingloop_factory
mechanism?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no we don't need this. it was convenient to add it for my testing. sure, the same result can be achieved with the loop factory, but this feels cleaner, so I figured I'd suggest it and see what others think