Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks correct, but I think it would be more straightforward if you skip the
PyType_IS_GC
check (and always subtract the pre-header size.)_PyType_PreHeaderSize
returns zero for non-GC types.For context, here's an example in
_PyType_AllocNoTrack
that operates on GC and non-GC types and unconditionally adds the pre-header size:cpython/Objects/typeobject.c
Lines 1300 to 1301 in ecfd2d3