Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-101517: Attach line number to the RERAISE at the end of a try-except* #101768

Closed
wants to merge 3 commits into from
Closed

gh-101517: Attach line number to the RERAISE at the end of a try-except* #101768

wants to merge 3 commits into from

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Feb 10, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Feb 10, 2023
Closed
@iritkatriel iritkatriel reopened this Feb 13, 2023
hugovk
hugovk reviewed Feb 13, 2023
View reviewed changes
Lib/test/test_pdb.py Outdated
Comment on lines 1412 to 1431
"""See GH-101517

breakpoint in except* clause

>>> def test_function():
... try:
... raise ExceptionGroup("eg", [KeyError(), ValueError()])
... except* KeyError:
... breakpoint()
...
>>> with PdbTestInput([ # doctest: +NORMALIZE_WHITESPACE
... 'continue'
... ]):
... try:
... test_function()
... except Exception as e:
... print(repr(e))
ExceptionGroup('eg', [ValueError()])
>>>
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make patchcheck on the CI doesn't like these 5-space indents.

@iritkatriel
Copy link
Member Author

This is wrong, I'll do something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk left review comments

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iritkatriel @hugovk @bedevere-bot