Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-86509: docs for thread-local data - add link to _threading_local.py #101824

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

OTheDev
Copy link
Contributor

@OTheDev OTheDev commented Feb 11, 2023

Tries to fix #86509.

I think that a link is sufficient, though I'd be happy to expand the docstring onto the docs if desired!

fix2

@furkanonder
Copy link
Contributor

LGTM

@erlend-aasland erlend-aasland added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Mar 10, 2023
@erlend-aasland
Copy link
Contributor

I think that a link is sufficient.

It is definitely better than the status quo, so let's merge this as a first step. I'm not sure if it enough to close the linked issue, though.

Thanks for the patch.

@erlend-aasland erlend-aasland merged commit 53dceb5 into python:main Mar 10, 2023
@miss-islington
Copy link
Contributor

Thanks @OTheDev for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 10, 2023
…pythonGH-101824)

(cherry picked from commit 53dceb5)

Co-authored-by: Owain Davies <116417456+OTheDev@users.noreply.github.com>
@bedevere-bot
Copy link

GH-102575 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Mar 10, 2023
@bedevere-bot
Copy link

GH-102576 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Mar 10, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 10, 2023
…pythonGH-101824)

(cherry picked from commit 53dceb5)

Co-authored-by: Owain Davies <116417456+OTheDev@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Mar 10, 2023
…01824)

(cherry picked from commit 53dceb5)

Co-authored-by: Owain Davies <116417456+OTheDev@users.noreply.github.com>
@OTheDev
Copy link
Contributor Author

OTheDev commented Mar 10, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

threading.local documentation should be on the net...
5 participants