Skip to content

Finding a test_importlib refleak on aarch64 RHEL8 #101394 #101847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Feb 12, 2023

This reverts commit 39017e0.

I am experimenting to detect the source of the leak here: #101766

This PR was the first one that has a recorded history of this failure. However, it does not look directly related.

Refs #101394
Refs #101766

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 357c542 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 12, 2023
@sobolevn
Copy link
Member Author

sobolevn commented Feb 12, 2023

I am 95% certain, that this is not the case. Looks like Refleak was not run for a long period of time and it just happened to run on this PR. But, I have to start somewhere!

@corona10
Copy link
Member

corona10 commented Feb 12, 2023

I would like to recommend you fix the issue rather than reverting right away.

@corona10
Copy link
Member

Ah you are trying to check the refleak was caused by this PR.

@sobolevn
Copy link
Member Author

@corona10 yes :)

@sobolevn
Copy link
Member Author

sobolevn commented Feb 12, 2023

@corona10 @mdickinson wow, I amused to say that the failing job has passed: https://buildbot.python.org/all/#/builders/802/builds/630

@mdickinson
Copy link
Member

Hmm. Very interesting. Is there any way we can get access to the machine to debug directly? Or can we at least find out which test in test_import is leaking?

@mdickinson
Copy link
Member

It looks as though at least some recent runs (e.g., https://buildbot.python.org/all/#/builders/802/builds/629) that include the changes reverted in this PR do pass. Is it possible that the result is dependent on the order in which tests are run, or the ordering of files on the filesystem, or some such?

@corona10
Copy link
Member

@sobolevn It does not explain anything
https://buildbot.python.org/all/#/builders/802/builds/585 was already passed at #101394

@gvanrossum
Copy link
Member

Please, please, please. When you submit a PR to revert another PR, please always put in a comment explaining why. "Refs #XXX" is not sufficient. Please spend the extra few minutes to communicate.

@sobolevn
Copy link
Member Author

sobolevn commented Feb 13, 2023

@gvanrossum Got it! I've updated the description.

@sobolevn
Copy link
Member Author

sobolevn commented Feb 13, 2023

@corona10 yes, seems like it is a flaky case. Here's another build for the same PR: https://buildbot.python.org/all/#/builders/802/builds/582 And it fails :(

@sobolevn sobolevn changed the title Revert "gh-101266: Fix __sizeof__ for subclasses of int (#101394)" Finding a test_importlib refleak on aarch64 RHEL8 #101394 Feb 13, 2023
@corona10
Copy link
Member

I reproduce the issue on my docker environment


beginning 6 repetitions
123456
......
test_importlib leaked [134, 134, 134] references, sum=402
test_importlib leaked [56, 56, 56] memory blocks, sum=168
test_importlib failed (reference leak)

== Tests result: FAILURE ==

1 test failed:
    test_importlib

Total duration: 598 ms
Tests result: FAILURE
ran 1 tests/2
exit 2
Tests failed: continuing with this subtest

Tests (1):
* test.test_importlib.test_metadata_api.APITests.test_version_egg_info_file

Bisection completed in 16 iterations and 0:00:21
[root@65cf87cd990d cpython]#

@corona10
Copy link
Member

Closing the PR since the root PR was found

@corona10 corona10 closed this Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants