Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-100425: Update tutorial docs related to sum() accuracy #101854

Merged
merged 1 commit into from
Feb 19, 2023

Conversation

neuralstring
Copy link
Contributor

@neuralstring neuralstring commented Feb 12, 2023

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Feb 12, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Feb 12, 2023
Comment on lines -397 to 398
>>> sum([0.1]*10) == 1.0
>>> 0.1 + 0.1 + 0.1 + 0.1 + 0.1 + 0.1 + 0.1 + 0.1 + 0.1 + 0.1 == 1.0
False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm:

Running Release|x64 interpreter...
Python 3.12.0a5+ (heads/main:dfc2e065a2, Feb 12 2023, 11:14:56) [MSC v.1929 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> sum([0.1]*10) == 1.0
True
>>> 0.1 + 0.1 + 0.1 + 0.1 + 0.1 + 0.1 + 0.1 + 0.1 + 0.1 + 0.1 == 1.0
False

@rhettinger as an author of the referenced PR.

@arhadthedev arhadthedev changed the title Update tutorial docs related to sum() accuracy gh-100425: Update tutorial docs related to sum() accuracy Feb 12, 2023
@rhettinger rhettinger self-assigned this Feb 15, 2023
Copy link
Contributor

@rhettinger rhettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add doctest directives throughout this page. It would have been nice for this issue to have been detected automatically.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@Allimuzzaman
Copy link

file your system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants