-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct trivial grammar in reset_mock docs #101861
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reset_mock under unittest.mock had a singular 'argument' for a list of two, correct it to the plural, and add a - for keyword-only for good measure.
hugovk
approved these changes
Feb 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
hugovk
added
needs backport to 3.10
only security fixes
needs backport to 3.11
only security fixes
and removed
awaiting merge
labels
Feb 13, 2023
Thanks @s-t-e-v-e-n-k for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
GH-101869 is a backport of this pull request to the 3.11 branch. |
GH-101870 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 13, 2023
(cherry picked from commit a1f08f5) Co-authored-by: Steve Kowalik <steven@wedontsleep.org>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 13, 2023
(cherry picked from commit a1f08f5) Co-authored-by: Steve Kowalik <steven@wedontsleep.org>
miss-islington
added a commit
that referenced
this pull request
Feb 13, 2023
(cherry picked from commit a1f08f5) Co-authored-by: Steve Kowalik <steven@wedontsleep.org>
miss-islington
added a commit
that referenced
this pull request
Feb 13, 2023
(cherry picked from commit a1f08f5) Co-authored-by: Steve Kowalik <steven@wedontsleep.org>
carljm
added a commit
to carljm/cpython
that referenced
this pull request
Feb 13, 2023
* main: pythongh-101810: Remove duplicated st_ino calculation (pythonGH-101811) pythongh-92547: Purge sqlite3_enable_shared_cache() detection from configure (python#101873) pythonGH-100987: Refactor `_PyInterpreterFrame` a bit, to assist generator improvement. (pythonGH-100988) pythonGH-87849: Simplify stack effect of SEND and specialize it for generators and coroutines. (pythonGH-101788) Correct trivial grammar in reset_mock docs (python#101861) pythongh-101845: pyspecific: Fix i18n for availability directive (pythonGH-101846) pythongh-89792: Limit test_tools freeze test build parallelism based on the number of cores (python#101841) pythongh-85984: Utilize new "winsize" functions from termios in pty tests. (python#101831) pythongh-89792: Prevent test_tools from copying 1000M of "source" in freeze test (python#101837) Fix typo in test_fstring.py (python#101823) pythonGH-101797: allocate `PyExpat_CAPI` capsule on heap (python#101798) pythongh-101390: Fix docs for `imporlib.util.LazyLoader.factory` to properly call it a class method (pythonGH-101391)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reset_mock under unittest.mock had a singular 'argument' for a list of two, correct it to the plural, and add a - for keyword-only for good measure.