gh-101981: Update macOS workflow #101991
gh-101981: Update macOS workflow #101991
Conversation
corona10
commented
Feb 17, 2023
•
corona10
commented
- Issue: CI: intermittent macOS failures for make checksharedmods #101981
corona10
force-pushed
the
mac_os_fix
branch
7 times, most recently
from
7677da1 to
c170cca
Compare
corona10
changed the title
corona10
added
skip news
needs backport to 3.10
.github/workflows/build.yml
Outdated
| brew install pkg-config openssl@1.1 xz gdbm tcl-tk | ||
| echo "CFLAGS=-I$(brew --prefix gdbm)/include -I$(brew --prefix xz)/include" >> $GITHUB_ENV | ||
| echo "LDFLAGS=-L$(brew --prefix gdbm)/lib -I$(brew --prefix xz)/lib" >> $GITHUB_ENV | ||
| echo "PKG_CONFIG_PATH=$(brew --prefix tcl-tk)/lib/pkgconfig" >> $GITHUB_ENV |
There was a problem hiding this comment.
Why not follow the devguide recipe and use one shell line? Those variables should only be needed for the configure command
There was a problem hiding this comment.
- multi line string needs to declare sperate variable for this: https://trstringer.com/github-actions-multiline-strings/
So we use single line command most of cases.
There was a problem hiding this comment.
- multi line string needs to declare sperate variable for this: https://trstringer.com/github-actions-multiline-strings/
But the devguide recipe does not consist of multiple commands on multiple lines as in that link, i.e. it's not "in the form of an output from one step, and an input to another step". It's a single shell command that has been split across lines in the devguide for readability and it doesn't need to be. (The POSIX command language standard calls it a "simple command": "A simple command is a sequence of optional variable assignments and redirections, in any sequence, optionally followed by words and redirections, terminated by a control operator." There is no piping involved here.)
|
When you're done making the requested changes, leave the comment: |
|
I have made the requested changes; please review again I am thinking about how to resolve test_freeze_simple_script |
corona10
changed the title
corona10
force-pushed
the
mac_os_fix
branch
2 times, most recently
from
8c3019e to
28c8fa3
Compare
corona10
force-pushed
the
mac_os_fix
branch
2 times, most recently
from
ce7ba2e to
28c8fa3
Compare
corona10
changed the title
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @ned-deily: please review the changes made to this pull request. |
