Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-101981: Consolidate macOS configure steps in CI #102131

Merged
merged 3 commits into from
Feb 23, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Feb 21, 2023

Automerge-Triggered-By: GH:erlend-aasland

Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Let's see if it works :)

@erlend-aasland
Copy link
Contributor Author

LGTM, thanks! Let's see if it works :)

Thanks for the heads-up, I had forgotten about this :)

Now, I also adjusted the PKG_CONFIG_PATH variable to adhere to the recommendations of the devguide. We'll see how that fares.

@erlend-aasland
Copy link
Contributor Author

I'll have to look at the CI failure tomorrow; over and out from Scandinavia.

@corona10
Copy link
Member

corona10 commented Feb 22, 2023

It doesn't works and this is not the temproal issue.
it seems like test_toolsreference the GITHUB_ENV, so if we want to make this pass.
IMHO, we should make test_tools to reference the configure scope variable.

@erlend-aasland
Copy link
Contributor Author

See fix in #102152

@erlend-aasland erlend-aasland marked this pull request as ready for review February 23, 2023 14:34
@miss-islington
Copy link
Contributor

@erlend-aasland: Status check is done, and it's a failure or timed out ❌.

@miss-islington
Copy link
Contributor

Status check is done, and it's a success ✅.

@miss-islington miss-islington merged commit e07b304 into python:main Feb 23, 2023
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-102177 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 23, 2023
…2131)

(cherry picked from commit e07b304)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Automerge-Triggered-By: GH:erlend-aasland
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Feb 23, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 23, 2023
…2131)

(cherry picked from commit e07b304)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Automerge-Triggered-By: GH:erlend-aasland
@bedevere-bot
Copy link

GH-102178 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Feb 23, 2023
@erlend-aasland erlend-aasland deleted the fixup-macos-build-again branch February 23, 2023 17:11
miss-islington added a commit that referenced this pull request Feb 23, 2023
(cherry picked from commit e07b304)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Automerge-Triggered-By: GH:erlend-aasland
miss-islington added a commit that referenced this pull request Feb 23, 2023
(cherry picked from commit e07b304)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Automerge-Triggered-By: GH:erlend-aasland
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants