-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-101476: Use _PyType_GetModuleState where applicable #102188
gh-101476: Use _PyType_GetModuleState where applicable #102188
Conversation
erlend-aasland
commented
Feb 23, 2023
•
edited by bedevere-bot
Loading
edited by bedevere-bot
- Issue: Add internal API for fast module access from heap type methods #101476
I consider this a trivial and non-controversial PR; I intend to merge it as soon as the CI is green. If this turns out to be bad judgement from my side, I'm happy to revert it. |
I remember that there were some kinds of discussions to use public API as possible. |
Might be one piece of discussion I remember: #90699 (comment) |
At least with _xxsubinterpreters, I purposefully did not use any internal API. Ideally, non-builtin extensions would avoid internal API, generally. |
@ericsnowcurrently, @corona10: As the PR title says, I've only applied this where applicable. This implies extension modules that define |
I've reverted the change in _testmultiphase. |
BTW, thanks for working on this, @erlend-aasland! |
Thanks for comments and reviews, everyone! |