-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-95675 fix uid and gid at test_add_dir_getmember #102207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
uyw4687
commented
Feb 24, 2023
•
edited by bedevere-bot
Loading
edited by bedevere-bot
- Issue: test_tar test_add_dir_getmember fails if uid/gid is larger than 16777215 #95675
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
@@ -225,18 +225,17 @@ def test_add_dir_getmember(self): | |||
self.add_dir_and_getmember('bar') | |||
self.add_dir_and_getmember('a'*101) | |||
|
|||
@unittest.skipIf( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please skip the test if hasattr(os, 'getuid') is false or hasattr(os, 'getgid') is false.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
GH-102230 is a backport of this pull request to the 3.10 branch. |
GH-102231 is a backport of this pull request to the 3.11 branch. |
|