Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-102519: Add os.listdrives, os.listvolumes and os.listmounts on Windows #102544

Merged
merged 6 commits into from
Mar 10, 2023

Conversation

zooba
Copy link
Member

@zooba zooba commented Mar 8, 2023

@zooba zooba added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 9, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @zooba for commit cafd311 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 9, 2023
Modules/posixmodule.c Outdated Show resolved Hide resolved
Modules/posixmodule.c Outdated Show resolved Hide resolved
Co-authored-by: Eryk Sun <eryksun@gmail.com>
@zooba
Copy link
Member Author

zooba commented Mar 10, 2023

I'm going to go ahead and assume that if all you've found is whitespace, there are no problems left to find 😉

Thanks for the review, as always. Really appreciate having you check this stuff out

@zooba zooba merged commit cb35882 into python:main Mar 10, 2023
@zooba zooba deleted the gh-102519 branch March 10, 2023 12:21
@eryksun
Copy link
Contributor

eryksun commented Mar 10, 2023

I'm going to go ahead and assume that if all you've found is whitespace, there are no problems left to find wink

I thought you weren't finished yet since the PR doesn't document the new functions in "Doc/library/os.rst".

@zooba
Copy link
Member Author

zooba commented Mar 10, 2023

Weird, I definitely wrote those docs... I wonder where they've gone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants