GH-102711: Fix warnings found by clang #102712

parheliamm · 2023-03-15T01:59:03Z

There are some warnings if build python via clang:

/home/lge/rpmbuild/BUILD/Python-3.10.9/Parser/pegen.c:812:31: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
_PyPegen_clear_memo_statistics()
                              ^
                               void
/home/lge/rpmbuild/BUILD/Python-3.10.9/Parser/pegen.c:820:29: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
_PyPegen_get_memo_statistics()
                            ^
                             void

Fix it to make clang happy.

Issue: Warnings found by clang #102711

bedevere-bot · 2023-03-15T01:59:06Z

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

cpython-cla-bot · 2023-03-15T01:59:29Z

All commit authors signed the Contributor License Agreement.

Misc/NEWS.d/next/Build/2023-03-15-02-03-39.gh-issue-102711.zTkjts.rst

thesamesam · 2023-03-15T03:32:46Z

This looks fine and is analogous to e35ca41 / #99086.

There are some warnings if build python via clang: Parser/pegen.c:812:31: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] _PyPegen_clear_memo_statistics() ^ void Parser/pegen.c:820:29: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] _PyPegen_get_memo_statistics() ^ void Fix it to make clang happy. Signed-off-by: Chenxi Mao <chenxi.mao@suse.com>

parheliamm · 2023-03-16T00:14:00Z

@thesamesam @pablogsal @lysnikolaou
Would you please review the new patch set?

Any feedback would be appreciated.

Chenxi

miss-islington · 2023-03-28T08:52:26Z

Thanks @parheliamm for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

bedevere-bot · 2023-03-28T08:52:38Z

GH-103075 is a backport of this pull request to the 3.11 branch.

miss-islington · 2023-03-28T08:52:44Z

Thanks @parheliamm for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

bedevere-bot · 2023-03-28T08:52:44Z

GH-103076 is a backport of this pull request to the 3.10 branch.

miss-islington · 2023-03-28T08:52:44Z

Thanks @parheliamm for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington · 2023-03-28T08:52:51Z

Sorry, @parheliamm and @ambv, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 7703def37e4fa7d25c3d23756de8f527daa4e165 3.9

There are some warnings if build python via clang: Parser/pegen.c:812:31: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] _PyPegen_clear_memo_statistics() ^ void Parser/pegen.c:820:29: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] _PyPegen_get_memo_statistics() ^ void Fix it to make clang happy. (cherry picked from commit 7703def) Co-authored-by: Chenxi Mao <chenxi.mao@suse.com> Signed-off-by: Chenxi Mao <chenxi.mao@suse.com>

ambv · 2023-03-28T08:56:49Z

Actually, forget about the 3.9 backport as this isn't security-related.

There are some warnings if build python via clang: Parser/pegen.c:812:31: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] _PyPegen_clear_memo_statistics() ^ void Parser/pegen.c:820:29: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] _PyPegen_get_memo_statistics() ^ void Fix it to make clang happy. (cherry picked from commit 7703def) Signed-off-by: Chenxi Mao <chenxi.mao@suse.com> Co-authored-by: Chenxi Mao <chenxi.mao@suse.com>

bedevere-bot · 2023-03-28T10:09:17Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL7 LTO + PGO 3.11 has failed when building commit abd6e97.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/968/builds/741) and take a look at the build logs.
Check if the failure is related to this commit (abd6e97) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/968/builds/741

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

413 tests OK.

10 slowest tests:

test_tools: 7 min 27 sec
test_concurrent_futures: 2 min 31 sec
test_multiprocessing_spawn: 1 min 55 sec
test_multiprocessing_fork: 1 min 21 sec
test_multiprocessing_forkserver: 1 min 18 sec
test_asyncio: 1 min
test_tokenize: 51.0 sec
test_signal: 48.0 sec
test_unparse: 40.1 sec
test_io: 35.8 sec

1 test altered the execution environment:
test_asyncio

20 tests skipped:
test_devpoll test_gdb test_idle test_ioctl test_kqueue
test_launcher test_msilib test_smtpnet test_ssl test_startfile
test_tcl test_tix test_tk test_ttk_guionly test_ttk_textonly
test_turtle test_winconsoleio test_winreg test_winsound
test_zipfile64

Total duration: 11 min 16 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.11.edelsohn-rhel-z.lto-pgo/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_ace6d810'


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.11.edelsohn-rhel-z.lto-pgo/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_30b5d66e'


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.11.edelsohn-rhel-z.lto-pgo/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_ab68f943'

There are some warnings if build python via clang: Parser/pegen.c:812:31: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] _PyPegen_clear_memo_statistics() ^ void Parser/pegen.c:820:29: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] _PyPegen_get_memo_statistics() ^ void Fix it to make clang happy. Signed-off-by: Chenxi Mao <chenxi.mao@suse.com>

parheliamm requested review from pablogsal and lysnikolaou as code owners March 15, 2023 01:59

bedevere-bot mentioned this pull request Mar 15, 2023

Warnings found by clang #102711

Closed

bedevere-bot added the awaiting review label Mar 15, 2023

thesamesam reviewed Mar 15, 2023

View reviewed changes

Misc/NEWS.d/next/Build/2023-03-15-02-03-39.gh-issue-102711.zTkjts.rst Outdated Show resolved Hide resolved

parheliamm force-pushed the main branch from 83a17fb to 2f1e655 Compare March 15, 2023 05:34

ambv changed the title ~~[3.9][3.10][3.11] GH-102711: Fix warnings found by clang~~ GH-102711: Fix warnings found by clang Mar 28, 2023

ambv added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Mar 28, 2023

ambv merged commit 7703def into python:main Mar 28, 2023

bedevere-bot removed the awaiting review label Mar 28, 2023

bedevere-bot removed the needs backport to 3.11 only security fixes label Mar 28, 2023

ambv added needs backport to 3.9 only security fixes needs backport to 3.11 only security fixes labels Mar 28, 2023

bedevere-bot removed the needs backport to 3.10 only security fixes label Mar 28, 2023

miss-islington assigned ambv Mar 28, 2023

ambv removed the needs backport to 3.9 only security fixes label Mar 28, 2023

arhadthedev mentioned this pull request Apr 18, 2023

Netlify preview builds silently fail with Deploy Preview canceled #103604

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GH-102711: Fix warnings found by clang #102712

GH-102711: Fix warnings found by clang #102712

parheliamm commented Mar 15, 2023 •

edited by bedevere-bot

Loading

bedevere-bot commented Mar 15, 2023

cpython-cla-bot bot commented Mar 15, 2023 •

edited

Loading

thesamesam commented Mar 15, 2023

parheliamm commented Mar 16, 2023

miss-islington commented Mar 28, 2023

bedevere-bot commented Mar 28, 2023

miss-islington commented Mar 28, 2023

bedevere-bot commented Mar 28, 2023

miss-islington commented Mar 28, 2023

miss-islington commented Mar 28, 2023

ambv commented Mar 28, 2023

bedevere-bot commented Mar 28, 2023

GH-102711: Fix warnings found by clang #102712

GH-102711: Fix warnings found by clang #102712

Conversation

parheliamm commented Mar 15, 2023 • edited by bedevere-bot Loading

bedevere-bot commented Mar 15, 2023

cpython-cla-bot bot commented Mar 15, 2023 • edited Loading

thesamesam commented Mar 15, 2023

parheliamm commented Mar 16, 2023

miss-islington commented Mar 28, 2023

bedevere-bot commented Mar 28, 2023

miss-islington commented Mar 28, 2023

bedevere-bot commented Mar 28, 2023

miss-islington commented Mar 28, 2023

miss-islington commented Mar 28, 2023

ambv commented Mar 28, 2023

bedevere-bot commented Mar 28, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

parheliamm commented Mar 15, 2023 •

edited by bedevere-bot

Loading

cpython-cla-bot bot commented Mar 15, 2023 •

edited

Loading