Skip to content

GH-102748: remove legacy support for generator based coroutines from asyncio.iscoroutine #102749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 16, 2023
Merged

GH-102748: remove legacy support for generator based coroutines from asyncio.iscoroutine #102749

merged 8 commits into from
Mar 16, 2023

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Mar 16, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Mar 16, 2023
Closed
AlexWaygood
AlexWaygood reviewed Mar 16, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit:

@kumaraditya303 kumaraditya303 added topic-asyncio 3.12 only security fixes labels Mar 16, 2023
AlexWaygood
AlexWaygood reviewed Mar 16, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another tiny docs nit

@kumaraditya303 @AlexWaygood
Apply suggestions from code review
47caefd 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
AlexWaygood reviewed Mar 16, 2023
View reviewed changes
kumaraditya303 and others added 2 commits March 16, 2023 14:02
@kumaraditya303 @AlexWaygood
Update Misc/NEWS.d/next/Library/2023-03-16-08-17-29.gh-issue-102748.W…
31049b1 
…NACpI.rst

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@kumaraditya303 @AlexWaygood
Update Doc/whatsnew/3.12.rst
14ea9a6 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
AlexWaygood approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumaraditya303 kumaraditya303 merged commit adaed17 into python:main Mar 16, 2023
@kumaraditya303 kumaraditya303 deleted the legacy branch March 16, 2023 14:58
carljm added a commit to carljm/cpython that referenced this pull request Mar 17, 2023
@carljm
Merge branch 'main' into inlinecomp2
1a8f4a0 
* main: (34 commits)
  pythongh-102701: Fix overflow in dictobject.c (pythonGH-102750)
  pythonGH-78530: add support for generators in `asyncio.wait` (python#102761)
  Increase stack reserve size for Windows debug builds to avoid test crashes (pythonGH-102764)
  pythongh-102755: Add PyErr_DisplayException(exc) (python#102756)
  Fix outdated note about 'int' rounding or truncating (python#102736)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (python#102760)
  pythongh-99726: Improves correctness of stat results for Windows, and uses faster API when available (pythonGH-102149)
  pythongh-102192: remove redundant exception fields from ssl module socket (python#102466)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (python#102743)
  pythongh-102737: Un-ignore ceval.c in the CI globals check (pythongh-102745)
  pythonGH-102748: remove legacy support for generator based coroutines from `asyncio.iscoroutine` (python#102749)
  pythongh-102721: Improve coverage of `_collections_abc._CallableGenericAlias` (python#102722)
  pythonGH-102653: Make recipe docstring show the correct distribution (python#102742)
  Add comments to `{typing,_collections_abc}._type_repr` about each other (python#102752)
  pythongh-102594: PyErr_SetObject adds note to exception raised on normalization error (python#102675)
  pythongh-94440: Fix issue of ProcessPoolExecutor shutdown hanging (python#94468)
  pythonGH-100112:  avoid using iterable coroutines in asyncio internally (python#100128)
  pythongh-102690: Use Edge as fallback in webbrowser instead of IE (python#102691)
  pythongh-102660: Fix Refleaks in import.c (python#102744)
  pythongh-102738: remove from cases generator the code related to register instructions (python#102739)
  ...
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
@kumaraditya303 @AlexWaygood @Fidget-Spinner
pythonGH-102748: remove legacy support for generator based coroutines…
a123f26 
… from `asyncio.iscoroutine` (python#102749)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@kumaraditya303 @AlexWaygood @warsaw
pythonGH-102748: remove legacy support for generator based coroutines…
ea7834f 
… from `asyncio.iscoroutine` (python#102749)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@harshil21 harshil21 mentioned this pull request Jun 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@gvanrossum gvanrossum gvanrossum approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

+1 more reviewer

@mokko mokko mokko left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3.12 only security fixes topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kumaraditya303 @mokko @gvanrossum @AlexWaygood @bedevere-bot