Skip to content

Fix typo: _swapped_bytes_ #102773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hauntsaninja merged 2 commits into from
Mar 25, 2023
Merged

Fix typo: _swapped_bytes_ #102773

hauntsaninja merged 2 commits into from
Mar 25, 2023

Conversation

@matthiasgoergens
Copy link
Contributor

@matthiasgoergens matthiasgoergens commented Mar 17, 2023

It's a minor typo, but it makes for a misleading comment. Let's fix it.

@matthiasgoergens
Fix typo: _swapped_bytes_
362d682 
It's a minor typo, but it makes for a misleading comment.  Let's fix it.
@matthiasgoergens
Copy link
Contributor Author

matthiasgoergens commented Mar 17, 2023

@gpshead A very small incidental fix for ctypes.

Eclips4
Eclips4 approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@Eclips4 Eclips4 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to

cpython/Lib/ctypes/_endian.py

Line 51 in 4f5774f

_swappedbytes_ = None

This seems right. Also, i think there is no need in NEWS
LGTM

@arhadthedev arhadthedev added skip issue skip news stdlib Standard Library Python modules in the Lib/ directory labels Mar 22, 2023
hauntsaninja
hauntsaninja approved these changes Mar 25, 2023
View reviewed changes
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@hauntsaninja hauntsaninja merged commit 30a306c into python:main Mar 25, 2023
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
@matthiasgoergens @Fidget-Spinner
Fix typo in _swappedbytes_ in ctypes comment (python#102773)
0831f21 
It's a minor typo, but it makes for a misleading comment.  Let's fix it.
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@matthiasgoergens @warsaw
Fix typo in _swappedbytes_ in ctypes comment (python#102773)
f74565e 
It's a minor typo, but it makes for a misleading comment.  Let's fix it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

@furkanonder furkanonder furkanonder approved these changes

@Eclips4 Eclips4 Eclips4 approved these changes

Assignees

No one assigned

Labels

skip issue skip news stdlib Standard Library Python modules in the Lib/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@matthiasgoergens @hauntsaninja @furkanonder @Eclips4 @arhadthedev @bedevere-bot