-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-76846, GH-85281: Call __new__()
and __init__()
on pathlib subclasses
#102789
Merged
barneygale
merged 9 commits into
python:main
from
barneygale:gh-76846-unify-constructors
Apr 3, 2023
Merged
GH-76846, GH-85281: Call __new__()
and __init__()
on pathlib subclasses
#102789
barneygale
merged 9 commits into
python:main
from
barneygale:gh-76846-unify-constructors
Apr 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 32d13ba.
zooba
reviewed
Mar 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (with what I marked). Any concerns in particular that you'd like me to take a closer look at?
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
barneygale
commented
Mar 27, 2023
barneygale
commented
Mar 27, 2023
I think those were my only areas of concern! Thanks for the review :) |
Are you happy for me to merge, @zooba? |
All yours |
This was referenced Apr 3, 2023
gaogaotiantian
pushed a commit
to gaogaotiantian/cpython
that referenced
this pull request
Apr 8, 2023
…pathlib subclasses (pythonGH-102789) Fix an issue where `__new__()` and `__init__()` were not called on subclasses of `pathlib.PurePath` and `Path` in some circumstances. Paths are now normalized on-demand. This speeds up path construction, `p.joinpath(q)`, and `p / q`. Co-authored-by: Steve Dower <steve.dower@microsoft.com>
warsaw
pushed a commit
to warsaw/cpython
that referenced
this pull request
Apr 11, 2023
…pathlib subclasses (pythonGH-102789) Fix an issue where `__new__()` and `__init__()` were not called on subclasses of `pathlib.PurePath` and `Path` in some circumstances. Paths are now normalized on-demand. This speeds up path construction, `p.joinpath(q)`, and `p / q`. Co-authored-by: Steve Dower <steve.dower@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where
__new__()
and__init__()
were not called on subclasses ofpathlib.PurePath
andPath
in some circumstances.Specifically, the
_from_parsed_parts()
constructor -- which is used when iterating directories, parents, and inwith_name()
and friends -- has been altered as follows:This change alone has an unfortunate effect: paths constructed this way are re-parsed and re-normalized even though we have the fully normalized path at hand.
To fix this, we change the main constructor to not normalize paths. Instead, paths are normalized on-demand. This also speeds up path construction,
p.joinpath(q)
, andp / q
.