gh-101975: Fixed a potential SegFault on garbage collection #102803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markshannon
approved these changes
Mar 18, 2023
Member
markshannon
left a comment
markshannon
left a comment
There was a problem hiding this comment.
Looks good.
I quickly checked the other uses of _PyFrame_GetStackPointer(frame) and this is the odd one out.
Contributor
|
Thanks @gaogaotiantian for the PR, and @markshannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Contributor
|
Sorry, @gaogaotiantian and @markshannon, I could not cleanly backport this to |
markshannon
pushed a commit
to faster-cpython/cpython
that referenced
this pull request
Mar 18, 2023
|
GH-102807 is a backport of this pull request to the 3.11 branch. |
markshannon
added a commit
that referenced
this pull request
Mar 20, 2023
Fidget-Spinner
pushed a commit
to Fidget-Spinner/cpython
that referenced
this pull request
Mar 27, 2023
warsaw
pushed a commit
to warsaw/cpython
that referenced
this pull request
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
frame->stacktop = 1is missing on trace entry which could cause thegcon another thread to access freed memory.