Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-102509: Ignore acceptable access of an uninitialized value #102838

Closed
wants to merge 3 commits into from

Conversation

illia-v
Copy link
Contributor

@illia-v illia-v commented Mar 20, 2023

This is done to ignore an error on accessing an uninitialized integer without an adverse effect.
#102509 (comment)

@illia-v illia-v changed the title gh-102509: Create an ignore list for sanitizers gh-102509: Ignore acceptable access of an uninitialized value Mar 20, 2023
@erlend-aasland
Copy link
Contributor

AFAICS, this is an alternative to #102510. Let's wait an see what the Marks decide over there first.

@erlend-aasland erlend-aasland marked this pull request as draft March 22, 2023 10:02
@erlend-aasland erlend-aasland removed their request for review May 8, 2023 07:55
@arhadthedev
Copy link
Member

Let's wait an see what the Marks decide over there first.

@mdickinson

@illia-v
Copy link
Contributor Author

illia-v commented May 17, 2023

It will be nice to have the error fixed in the first beta of 3.12.

I've just checked that #101291 has not affected the use of the uninitialized value yet (see #102510 (comment) for previous expectations) and running CC=clang ./configure --with-memory-sanitizer && make -j12 still fails without the patch.

@mdickinson
Copy link
Member

@arhadthedev

@mdickinson

I think this one's for @markshannon to decide; he has better awareness of the #102510 performance trade-offs than I do. (And it's "his" code, in some sense.)

@illia-v
Copy link
Contributor Author

illia-v commented Jul 31, 2023

Closing this because the value was initialized explicitly in #102510 and #107464

@illia-v illia-v closed this Jul 31, 2023
@illia-v illia-v deleted the gh-102509-ignorelist branch July 31, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants