gh-102860: improve performance of compiler's instr_sequence_to_cfg #102861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iritkatriel
added
skip news
interpreter-core
iritkatriel
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 4a84199 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
carljm
approved these changes
Mar 21, 2023
Comment on lines
+631
to
+637
| if (HAS_TARGET(opcode)) { | ||
| int offset = seq->s_labelmap[oparg]; | ||
| assert(offset >= 0 && offset < seq->s_used); | ||
| int lbl = offset2lbl[offset]; | ||
| assert(lbl >= 0 && lbl < seq->s_labelmap_size); | ||
| oparg = lbl; | ||
| } |
There was a problem hiding this comment.
I guess this is required now because we only call cfg_builder_use_label for the one canonical label for an offset, rather than for every label? So we have to ensure we use the canonical label for jump targets also.
Fidget-Spinner
pushed a commit
to Fidget-Spinner/cpython
that referenced
this pull request
Mar 27, 2023
warsaw
pushed a commit
to warsaw/cpython
that referenced
this pull request
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102860.